Appreciated your proposal for the better subject. Will do it.
Thanks,
Irene
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bob Feng
Sent: Tuesday, June 2, 2020 5:18 AM
To: devel@edk2.groups.io; Irene Park
Subject: Re: [edk2-devel] [PATCH v2] BaseTools/Python: sys.exit(1
Irene,
This patch looks good. For the subject, I think it's that the build will exit
with 1 when the AutoGen error occurred.
Would you update the subject to make it more clear?
With the subject update,
Reivewed-by: Bob Feng
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On
Hi Bob,
Would you please review this patch again?
Thank you,
Irene
-Original Message-
From: devel@edk2.groups.io On Behalf Of Irene Park
Sent: Monday, June 1, 2020 4:28 PM
To: devel@edk2.groups.io
Cc: Irene Park
Subject: [edk2-devel] [PATCH v2] BaseTools/Python: sys.exit(1) when error
o
