Re: [edk2-devel] [PATCH v1 v1 1/1] MdePkg: Add error output for IoLib.c

2024-08-13 Thread Michael D Kinney
> -Original Message- > From: Ming Huang > Sent: Tuesday, August 13, 2024 7:05 PM > To: Kinney, Michael D ; devel@edk2.groups.io; > gaolim...@byosoft.com.cn; Liu, Zhiguang > Cc: ming.hua...@outlook.com > Subject: Re: [PATCH v1 v1 1/1] MdePkg: Add error output for IoLib.c > > > > On 8/

Re: [edk2-devel] [PATCH v1 v1 1/1] MdePkg: Add error output for IoLib.c

2024-08-13 Thread Ming Huang
On 8/13/24 11:29 PM, Kinney, Michael D wrote: > Hi, > > We have moved to a PR based review process. Can you change this to a PR? OK, I will change this to a PR. > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process > > Also, this change may impact the code si

Re: [edk2-devel] [PATCH v1 v1 1/1] MdePkg: Add error output for IoLib.c

2024-08-13 Thread Michael D Kinney
Hi, We have moved to a PR based review process. Can you change this to a PR? https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process Also, this change may impact the code size and performance of these APIs. When ASSERTS() are disabled, an optimizing compiler can inline