Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Fix issue with ACPI table creation

2023-11-07 Thread Dandan Bi
The changes looks good to me. One minor comment about the coding style: Could we make the "else if" at the same line with brace "}", which is aligned with current edk2 coding style, rather than in a new line ? Thanks. Like: } else if (((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE *)ChildTable)->D

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Fix issue with ACPI table creation

2023-10-03 Thread Dhaval Sharma
Hi everyone, A gentle remonder to review the patch.. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109305): https://edk2.groups.io/g/devel/message/109305 Mute This Topic: https://groups.io/mt/101633356/21656 Group Owner: devel+ow...@edk2