Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-09 Thread Laszlo Ersek
On 06/09/21 14:25, Dov Murik wrote: > > > On 08/06/2021 18:59, Laszlo Ersek wrote: >> On 06/08/21 14:09, Dov Murik wrote: >>> On 08/06/2021 13:59, Laszlo Ersek wrote: On 06/08/21 11:57, Dov Murik wrote: >> > >>> >>> But if we go with (1) -- do you (and Ard) prefer: >>> >>> (a) leave X86Qemu

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-09 Thread Dov Murik
On 08/06/2021 18:59, Laszlo Ersek wrote: > On 06/08/21 14:09, Dov Murik wrote: >> On 08/06/2021 13:59, Laszlo Ersek wrote: >>> On 06/08/21 11:57, Dov Murik wrote: > >> >> But if we go with (1) -- do you (and Ard) prefer: >> >> (a) leave X86QemuLoadImageLib as it is in master; >> >> -or- >> >>

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-08 Thread Laszlo Ersek
On 06/08/21 14:49, Ard Biesheuvel wrote: > On Tue, 8 Jun 2021 at 12:59, Laszlo Ersek wrote: >> >> Ard, >> >> do you have any comments please, on the topic at the bottom? >> >> My comments follow: >> >> On 06/08/21 11:57, Dov Murik wrote: >>> >>> >>> On 04/06/2021 14:26, Laszlo Ersek wrote: On

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-08 Thread Laszlo Ersek
On 06/08/21 14:09, Dov Murik wrote: > On 08/06/2021 13:59, Laszlo Ersek wrote: >> On 06/08/21 11:57, Dov Murik wrote: >>> I started working on that, and managed to remove all QemuFwCfg* >>> calls in the main path of QemuLoadKernelImage (so far working on >>> X86QemuLoadImageLib.c). That works fin

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-08 Thread Ard Biesheuvel
On Tue, 8 Jun 2021 at 12:59, Laszlo Ersek wrote: > > Ard, > > do you have any comments please, on the topic at the bottom? > > My comments follow: > > On 06/08/21 11:57, Dov Murik wrote: > > > > > > On 04/06/2021 14:26, Laszlo Ersek wrote: > >> On 06/04/21 12:30, Dov Murik wrote: > >> > > > > ...

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-08 Thread Dov Murik
On 08/06/2021 13:59, Laszlo Ersek wrote: > Ard, > > do you have any comments please, on the topic at the bottom? > > My comments follow: > > On 06/08/21 11:57, Dov Murik wrote: >> >> >> On 04/06/2021 14:26, Laszlo Ersek wrote: >>> On 06/04/21 12:30, Dov Murik wrote: >>> >> >> ... >>

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-08 Thread Laszlo Ersek
Ard, do you have any comments please, on the topic at the bottom? My comments follow: On 06/08/21 11:57, Dov Murik wrote: > > > On 04/06/2021 14:26, Laszlo Ersek wrote: >> On 06/04/21 12:30, Dov Murik wrote: >> > > ... > >>> [Ard, please see this one question:] - A major complicat

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-08 Thread Dov Murik
On 04/06/2021 14:26, Laszlo Ersek wrote: > On 06/04/21 12:30, Dov Murik wrote: > ... >> >>> [Ard, please see this one question:] >>> >>> - A major complication for hashing all three of: kernel, initrd, >>> cmdline, is that the *fetching* of this triplet is split between two >>> places. (Well,

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-07 Thread Laszlo Ersek
On 06/06/21 15:21, Dov Murik wrote: > > > On 04/06/2021 14:26, Laszlo Ersek wrote: >> On 06/04/21 12:30, Dov Murik wrote: >> >>> So I argue to keep the existing approach with two separate areas: >>> existing one for injected secrets, and new one for a table of approved >>> hashes (filled by QEMU

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-06 Thread Dov Murik
On 04/06/2021 14:26, Laszlo Ersek wrote: > On 06/04/21 12:30, Dov Murik wrote: > >> So I argue to keep the existing approach with two separate areas: >> existing one for injected secrets, and new one for a table of approved >> hashes (filled by QEMU and updated as initial encrypted measured gue

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-04 Thread Laszlo Ersek
On 06/04/21 12:30, Dov Murik wrote: > So I argue to keep the existing approach with two separate areas: > existing one for injected secrets, and new one for a table of approved > hashes (filled by QEMU and updated as initial encrypted measured guest > memory). OK. > If the issue is MEMFD space,

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-04 Thread Dov Murik
Thank you Laszlo for reviewing this. On 01/06/2021 15:11, Laszlo Ersek wrote: > Ard, > > I'll have a specific question for you below; please feel free to jump > forward (search for your name). Thanks. > > Dov, my comments below: > > On 05/25/21 07:31, Dov Murik wrote: >> Booting with SEV preve

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-03 Thread Laszlo Ersek
Hi James, thanks for the answer, one comment below: On 06/02/21 20:10, James Bottomley wrote: > On Tue, 2021-06-01 at 14:11 +0200, Laszlo Ersek wrote: >> Ard, >> >> I'll have a specific question for you below; please feel free to jump >> forward (search for your name). Thanks. >> >> Dov, my comme

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-02 Thread James Bottomley
On Tue, 2021-06-01 at 14:11 +0200, Laszlo Ersek wrote: > Ard, > > I'll have a specific question for you below; please feel free to jump > forward (search for your name). Thanks. > > Dov, my comments below: > > On 05/25/21 07:31, Dov Murik wrote: > > Booting with SEV prevented the loading of kern

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-01 Thread Laszlo Ersek
On 06/01/21 15:20, Ard Biesheuvel wrote: > On Tue, 1 Jun 2021 at 14:12, Laszlo Ersek wrote: >> > ... >> - A major complication for hashing all three of: kernel, initrd, >> cmdline, is that the *fetching* of this triplet is split between two >> places. (Well, it is split between *three* places in f

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-01 Thread Ard Biesheuvel
On Tue, 1 Jun 2021 at 14:12, Laszlo Ersek wrote: > ... > - A major complication for hashing all three of: kernel, initrd, > cmdline, is that the *fetching* of this triplet is split between two > places. (Well, it is split between *three* places in fact, but I'm going > to ignore LinuxInitrdDynamic

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-06-01 Thread Laszlo Ersek
Ard, I'll have a specific question for you below; please feel free to jump forward (search for your name). Thanks. Dov, my comments below: On 05/25/21 07:31, Dov Murik wrote: > Booting with SEV prevented the loading of kernel, initrd, and kernel > command-line via QEMU fw_cfg interface because t

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-05-27 Thread Laszlo Ersek
On 05/25/21 07:31, Dov Murik wrote: > Booting with SEV prevented the loading of kernel, initrd, and kernel > command-line via QEMU fw_cfg interface because they arrive from the VMM > which is untrusted in SEV. > > However, in some cases the kernel, initrd, and cmdline are not secret > but should n

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-05-25 Thread Dov Murik
On 26/05/2021 2:37, Brijesh Singh wrote: > > On 5/25/21 6:15 PM, James Bottomley wrote: >> On Tue, 2021-05-25 at 15:33 -0500, Tom Lendacky wrote: >>> On 5/25/21 3:08 PM, Dov Murik wrote: Hi Brijesh, On 25/05/2021 18:48, Brijesh Singh wrote: > On 5/25/21 12:31 AM, Dov Murik wr

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-05-25 Thread Brijesh Singh
On 5/25/21 6:15 PM, James Bottomley wrote: > On Tue, 2021-05-25 at 15:33 -0500, Tom Lendacky wrote: >> On 5/25/21 3:08 PM, Dov Murik wrote: >>> Hi Brijesh, >>> >>> On 25/05/2021 18:48, Brijesh Singh wrote: On 5/25/21 12:31 AM, Dov Murik wrote: > Booting with SEV prevented the loading of

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-05-25 Thread James Bottomley
On Tue, 2021-05-25 at 15:33 -0500, Tom Lendacky wrote: > On 5/25/21 3:08 PM, Dov Murik wrote: > > Hi Brijesh, > > > > On 25/05/2021 18:48, Brijesh Singh wrote: > > > On 5/25/21 12:31 AM, Dov Murik wrote: > > > > Booting with SEV prevented the loading of kernel, initrd, and > > > > kernel command-l

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-05-25 Thread Lendacky, Thomas
On 5/25/21 3:08 PM, Dov Murik wrote: > Hi Brijesh, > > On 25/05/2021 18:48, Brijesh Singh wrote: >> >> On 5/25/21 12:31 AM, Dov Murik wrote: >>> Booting with SEV prevented the loading of kernel, initrd, and kernel >>> command-line via QEMU fw_cfg interface because they arrive from the VMM >>> whic

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-05-25 Thread Dov Murik
Hi Brijesh, On 25/05/2021 18:48, Brijesh Singh wrote: > > On 5/25/21 12:31 AM, Dov Murik wrote: >> Booting with SEV prevented the loading of kernel, initrd, and kernel >> command-line via QEMU fw_cfg interface because they arrive from the VMM >> which is untrusted in SEV. >> >> However, in some c

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-05-25 Thread Brijesh Singh
On 5/25/21 12:31 AM, Dov Murik wrote: > Booting with SEV prevented the loading of kernel, initrd, and kernel > command-line via QEMU fw_cfg interface because they arrive from the VMM > which is untrusted in SEV. > > However, in some cases the kernel, initrd, and cmdline are not secret > but shoul

Re: [edk2-devel] [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline

2021-05-25 Thread Dov Murik
On 25/05/2021 8:31, Dov Murik wrote: > Booting with SEV prevented the loading of kernel, initrd, and kernel > command-line via QEMU fw_cfg interface because they arrive from the VMM > which is untrusted in SEV. > > However, in some cases the kernel, initrd, and cmdline are not secret > but shou