Re: [edk2-devel] [PATCH V2 28/28] OvmfPkg: Add LocalApicTimerDxe

2021-10-25 Thread Gerd Hoffmann
> > I still think we don't need a runtime switch. Continue using 8254TimerDxe > > for > > CSM_ENABLE=TRUE builds should be enough. > > > Thanks for your detailed explanation. I agree we don't need a runtime switch. > Just use CSM_ENABLE=TRUE in *.dsc/*.fdf to switch 8254 and lapic in build > t

Re: [edk2-devel] [PATCH V2 28/28] OvmfPkg: Add LocalApicTimerDxe

2021-10-25 Thread Min Xu
On October 25, 2021 7:28 PM, Gerd Hoffmann wrote: > On Mon, Oct 25, 2021 at 07:37:33AM +, Min Xu wrote: > > On October 12, 2021 9:02 PM, Gerd Hoffmann wrote: > > > On Tue, Oct 05, 2021 at 11:39:39AM +0800, Min Xu wrote: > > > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > > > >

Re: [edk2-devel] [PATCH V2 28/28] OvmfPkg: Add LocalApicTimerDxe

2021-10-25 Thread Gerd Hoffmann
On Mon, Oct 25, 2021 at 07:37:33AM +, Min Xu wrote: > On October 12, 2021 9:02 PM, Gerd Hoffmann wrote: > > On Tue, Oct 05, 2021 at 11:39:39AM +0800, Min Xu wrote: > > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > > > > > TDX guest supports LocalApicTimer. But in current OvmfPk

Re: [edk2-devel] [PATCH V2 28/28] OvmfPkg: Add LocalApicTimerDxe

2021-10-25 Thread Min Xu
On October 12, 2021 9:02 PM, Gerd Hoffmann wrote: > On Tue, Oct 05, 2021 at 11:39:39AM +0800, Min Xu wrote: > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > > > TDX guest supports LocalApicTimer. But in current OvmfPkg the > > supported timer is 8254TimerDxe. So > > gUefiOvmfPkgToke

Re: [edk2-devel] [PATCH V2 28/28] OvmfPkg: Add LocalApicTimerDxe

2021-10-14 Thread Yao, Jiewen
n L > ; Brijesh Singh ; Erdem > Aktas ; James Bottomley ; > Yao, Jiewen ; Tom Lendacky > > Subject: RE: [edk2-devel] [PATCH V2 28/28] OvmfPkg: Add LocalApicTimerDxe > > On October 12, 2021 9:02 PM, Gerd Hoffmann wrote: > > On Tue, Oct 05, 2021 at 11:39:

Re: [edk2-devel] [PATCH V2 28/28] OvmfPkg: Add LocalApicTimerDxe

2021-10-13 Thread Min Xu
On October 12, 2021 9:02 PM, Gerd Hoffmann wrote: > On Tue, Oct 05, 2021 at 11:39:39AM +0800, Min Xu wrote: > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > > > TDX guest supports LocalApicTimer. But in current OvmfPkg the > > supported timer is 8254TimerDxe. So > > gUefiOvmfPkgToke

Re: [edk2-devel] [PATCH V2 28/28] OvmfPkg: Add LocalApicTimerDxe

2021-10-12 Thread Gerd Hoffmann
On Tue, Oct 05, 2021 at 11:39:39AM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > TDX guest supports LocalApicTimer. But in current OvmfPkg the supported > timer is 8254TimerDxe. So gUefiOvmfPkgTokenSpaceGuid.PcdTimerSelector > is introduced to select the runni