Re: [edk2-devel] [PATCH V2 13/28] UefiCpuPkg: Enable Tdx support in MpInitLib

2021-10-14 Thread Min Xu
On October 13, 2021 2:01 PM, Ray Ni wrote: > Min, > The change is to provide a totally different MP service in TDX case. > It makes the MpInitLib more complicated. > > How about? > 1. Change CpuMpPei/CpuMpDxe to return directly in TDX case. > 2. Add new TdxCpuMpPei/TdxCpuMpDxe to provide a new set

Re: [edk2-devel] [PATCH V2 13/28] UefiCpuPkg: Enable Tdx support in MpInitLib

2021-10-13 Thread Gerd Hoffmann
On Thu, Oct 14, 2021 at 06:31:30AM +, Xu, Min M wrote: > On October 14, 2021 2:05 PM, Gerd Hoffmann wrote: > > On Thu, Oct 14, 2021 at 12:27:13AM +, Xu, Min M wrote: > > > On October 12, 2021 6:32 PM, Gerd Hoffman wrote: > > > > Hi, > > > > > > > > > + do { > > > > > +AsmCpuid (0, &L

Re: [edk2-devel] [PATCH V2 13/28] UefiCpuPkg: Enable Tdx support in MpInitLib

2021-10-13 Thread Min Xu
On October 14, 2021 2:05 PM, Gerd Hoffmann wrote: > On Thu, Oct 14, 2021 at 12:27:13AM +, Xu, Min M wrote: > > On October 12, 2021 6:32 PM, Gerd Hoffman wrote: > > > Hi, > > > > > > > + do { > > > > +AsmCpuid (0, &LargestEax, &Ebx, &Ecx, &Edx); > > > > > > Again: this should use PCD. > >

Re: [edk2-devel] [PATCH V2 13/28] UefiCpuPkg: Enable Tdx support in MpInitLib

2021-10-13 Thread Gerd Hoffmann
On Thu, Oct 14, 2021 at 12:27:13AM +, Xu, Min M wrote: > On October 12, 2021 6:32 PM, Gerd Hoffman wrote: > > Hi, > > > > > + do { > > > +AsmCpuid (0, &LargestEax, &Ebx, &Ecx, &Edx); > > > > Again: this should use PCD. > ConfidentialComputing PCD is set in PlatformPei. So any check of

Re: [edk2-devel] [PATCH V2 13/28] UefiCpuPkg: Enable Tdx support in MpInitLib

2021-10-13 Thread Min Xu
On October 12, 2021 6:32 PM, Gerd Hoffman wrote: > Hi, > > > + do { > > +AsmCpuid (0, &LargestEax, &Ebx, &Ecx, &Edx); > > Again: this should use PCD. ConfidentialComputing PCD is set in PlatformPei. So any check of this PCD should be after PlatformPei. MpInitLib will be included in CpuMpP

Re: [edk2-devel] [PATCH V2 13/28] UefiCpuPkg: Enable Tdx support in MpInitLib

2021-10-12 Thread Ni, Ray
Min, The change is to provide a totally different MP service in TDX case. It makes the MpInitLib more complicated. How about? 1. Change CpuMpPei/CpuMpDxe to return directly in TDX case. 2. Add new TdxCpuMpPei/TdxCpuMpDxe to provide a new set simple MP service in TDX case. This makes the whole co

Re: [edk2-devel] [PATCH V2 13/28] UefiCpuPkg: Enable Tdx support in MpInitLib

2021-10-12 Thread Gerd Hoffmann
Hi, > + do { > +AsmCpuid (0, &LargestEax, &Ebx, &Ecx, &Edx); Again: this should use PCD. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81823): https://edk2.groups.io/g/devel/message/81823 Mute This Topic: htt