Thanks Sami.
Regards,
Rohit
From: Sami Mujawar
Sent: 17 August 2022 10:46
To: Rohit Mathew ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller
to SSDT
Hi Rohit,
Apologies for the delay. I will pick this up once the merge window opens
Hi Rohit,
Apologies for the delay. I will pick this up once the merge window opens.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92512): https://edk2.groups.io/g/devel/message/92512
M
Gentle reminder for this patch series.
Regards,
Rohit
From: Rohit Mathew
Sent: 02 August 2022 14:51
To: devel@edk2.groups.io; Sami Mujawar
Cc: Thanu Rangarajan ; Thomas Abraham
; nd
Subject: RE: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller
to SSDT
Hi Sami,
Gentle
Hi Sami,
Gentle reminder for this patch series.
Regards,
Rohit.
From: devel@edk2.groups.io On Behalf Of Rohit Mathew via
groups.io
Sent: 25 July 2022 15:56
To: Thanu Rangarajan ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller
to SSDT
Hi
>
>
>
> Regards,
>
>
>
> Thanu
>
>
>
> *From:* Sami Mujawar
> *Date:* Monday, 25 July 2022 at 16:12
> *To:* Rohit Mathew , "devel@edk2.groups.io"
>
> *Cc:* Thanu Rangarajan , nd
> *Subject:* Re: [edk2-devel] [PATCH 2/2] Platform/
.
+ Samer for any additional comments/clarifications.
Regards,
Thanu
From: Sami Mujawar
Date: Monday, 25 July 2022 at 16:12
To: Rohit Mathew , "devel@edk2.groups.io"
Cc: Thanu Rangarajan , nd
Subject: Re: [edk2-devel] [PATCH 2/2] Platform/Sgi: Add serial debug controller
to SSDT
Hi Rohit,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 22/07/2022 01:46 pm, Rohit Mathew wrote:
Hi Sami,
Thank you for the review.
Regarding the use of Dynamic Tables Framework, there are no short term
plans to migrate to it. Please find my response for your commen
Hi Sami,
Thank you for the review.
Regarding the use of Dynamic Tables Framework, there are no short term plans to
migrate to it. Please find my response for your comment inline -
On Thu, Jul 21, 2022 at 01:42 PM, Sami Mujawar wrote:
>
> Hi Rohit,
>
> Have you considered moving to use Dynamic
Hi Rohit,
Have you considered moving to use Dynamic Tables Framework? There is
just too much repetition in this series which can be easily avoided. It
will also make the code more maintainable.
Apart from this I have a comment marked inline as [SAMI].
Regards,
Sami Mujawar
On 04/07/2022 05
