Re: [edk2-devel] [PATCH 2/2] CryptoPkg: Add BigNum NullLib

2022-02-08 Thread yi1 li
Hi I have created Bugzilla to describe why we need to add this feature: https://bugzilla.tianocore.org/show_bug.cgi?id=3828. We will provide related information by comments such Bin size difference and more. Thanks! -Original Message- From: Yao, Jiewen Sent: Monday, January 31, 2022 9

Re: [edk2-devel] [PATCH 2/2] CryptoPkg: Add BigNum NullLib

2022-01-30 Thread Yao, Jiewen
Hi Then I don’t understand why we need this feature. Please submit a bugzilla to describe the problem statement. (Not the solution) Also please provide the size difference in pei and smm before and after your patch. Not only the crypto bin but also the individual driver using crypto lib, such a

Re: [edk2-devel] [PATCH 2/2] CryptoPkg: Add BigNum NullLib

2022-01-30 Thread yi1 li
Hi Jiewen With build cmd 'build -p .\Edk2\CryptoPkg\CryptoPkg.dsc -t VS2019 -a X64 -D CRYPTO_SERVICES=ALL': CryptDxe.efi will be 813,504 bytes without CryptBn; will be 815,040 bytes with CryptBnNull; will be 815,360 bytes with CryptBn; This patch has little effect on binary size since the dependen

Re: [edk2-devel] [PATCH 2/2] CryptoPkg: Add BigNum NullLib

2022-01-29 Thread Yao, Jiewen
thank you since you are talking about size optimization, would you please share the result? thank you! Yao, Jiewen > 在 2022年1月30日,上午6:10,Li, Yi1 写道: > > This patch is used to add CryptBnNull library, which is used to > optimize code size. > > Signed-off-by: yi1 li > > Cc: Jiewen Yao > Cc