Re: [edk2-devel] [PATCH 1/6] SecurityPkg/TcgPpi: Add TcgPpi header file.

2020-08-03 Thread Yao, Jiewen
Subject: Re: [edk2-devel] [PATCH 1/6] SecurityPkg/TcgPpi: Add TcgPpi header file. The more I think about it, the more I like your idea of registering early and allowing a PPI notification callback. Is that something we could get in this change, or would it be best to open a new BZ to track that

Re: [edk2-devel] [PATCH 1/6] SecurityPkg/TcgPpi: Add TcgPpi header file.

2020-08-03 Thread Bret Barkelew via groups.io
.groups.io on behalf of Bret Barkelew via groups.io Sent: Wednesday, July 15, 2020 8:32 AM To: Yao, Jiewen ; devel@edk2.groups.io ; Zhang, Qi1 Cc: Wang, Jian J Subject: [EXTERNAL] Re: [edk2-devel] [PATCH 1/6] SecurityPkg/TcgPpi: Add TcgPpi header file. Yeah, that’s kinda what I was thinking. It

Re: [edk2-devel] [PATCH 1/6] SecurityPkg/TcgPpi: Add TcgPpi header file.

2020-07-15 Thread Bret Barkelew via groups.io
J<mailto:jian.j.w...@intel.com> Subject: [EXTERNAL] RE: [edk2-devel] [PATCH 1/6] SecurityPkg/TcgPpi: Add TcgPpi header file. Maybe we can let TCG PEIM install the TCG_PPI *before* any measurement record, then the other PEIM can register a callback to record the HW ROT measurement ? Th

Re: [edk2-devel] [PATCH 1/6] SecurityPkg/TcgPpi: Add TcgPpi header file.

2020-07-15 Thread Yao, Jiewen
; devel@edk2.groups.io; Zhang, Qi1 Cc: Wang, Jian J Subject: Re: [edk2-devel] [PATCH 1/6] SecurityPkg/TcgPpi: Add TcgPpi header file. Hi Bret Do you have a full problem statement or Bugzilla? If we are resolving same problem, we can resolve altogether. If we are talking different problem, we can

Re: [edk2-devel] [PATCH 1/6] SecurityPkg/TcgPpi: Add TcgPpi header file.

2020-07-15 Thread Yao, Jiewen
ailto:jiewen.yao=intel@groups.io>> Sent: Tuesday, July 14, 2020 10:08:30 PM To: Zhang, Qi1 mailto:qi1.zh...@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> mailto:devel@edk2.groups.io>> Cc: Wang, Jian J mailto:jian.j.w...@intel.com>> Subject: [EXTERNAL]

Re: [edk2-devel] [PATCH 1/6] SecurityPkg/TcgPpi: Add TcgPpi header file.

2020-07-14 Thread Bret Barkelew via groups.io
From: devel@edk2.groups.io on behalf of Yao, Jiewen via groups.io Sent: Tuesday, July 14, 2020 10:08:30 PM To: Zhang, Qi1 ; devel@edk2.groups.io Cc: Wang, Jian J Subject: [EXTERNAL] Re: [edk2-devel] [PATCH 1/6] SecurityPkg/TcgPpi: Add TcgPpi header file

Re: [edk2-devel] [PATCH 1/6] SecurityPkg/TcgPpi: Add TcgPpi header file.

2020-07-14 Thread Yao, Jiewen
Thanks Qi. I just thought one use case that a PEIM may already have a calculated hash (https://github.com/tianocore/edk2/blob/master/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c#L652) We may need add a flag to support this pre-hash use case. Such as: > +(EFIAPI *EDKII_TCG_HASH_LOG_EXTEND_EVENT)( > > + I