Re: [edk2-devel] [PATCH 1/4] CryptoPkg: add new X509 function definition.

2022-10-09 Thread Qi Zhang
Sorry for confusing. This function is to format DataTimeStr to a DataTime object through DataTime buffer. So will change the function name to X509FormatDateTime() and modify this comment to "Format DataTimeStr to a DataTime object in DataTime buffer". Thanks! -Original Message- From: Y

Re: [edk2-devel] [PATCH 1/4] CryptoPkg: add new X509 function definition.

2022-10-09 Thread Yao, Jiewen
Hi I feel the function name X509SetDateTime() is very confusing. From the function comment, it means: "Format a DateTime object into DataTime Buffer". I also find the comment in X509GetValidity(), "x509SetDateTime to get a DateTime object from a DateTimeStr" It seems "DataTimeStr" is " DateTime