Re: [edk2-devel] [PATCH 0/7] CryptoPkg: Add BigNum and EC support to BaseCryptLib

2022-09-21 Thread Yao, Jiewen
Thank you! I will take care of it. > -Original Message- > From: Li, Yi1 > Sent: Wednesday, September 21, 2022 12:56 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, Xiaoyu1 > ; Jiang, Guomin > Subject: RE: [PATCH 0/7] CryptoPkg: Add BigNum and EC support to > BaseCryp

Re: [edk2-devel] [PATCH 0/7] CryptoPkg: Add BigNum and EC support to BaseCryptLib

2022-09-20 Thread yi1 li
Hi Jiewen, Thanks for review, changes done. Since both BN and EC extend many structures, splitting them will cause git conflicts, I've adjusted the order of patches: Ec commits are based on Bn commits. Just convenient for merge. Thanks, Yi -Original Message- From: Yao, Jiewen Sent: Wed

Re: [edk2-devel] [PATCH 0/7] CryptoPkg: Add BigNum and EC support to BaseCryptLib

2022-09-20 Thread Yao, Jiewen
Thanks for the patch. Please: 1) Separate BN and EC. Please submit 2 different patch sets. One for EC, the other for BN. 2) Please squash uncrustify tool update into previous patch. No need to submit a standalone one. 3) Please increase EDKII_CRYPTO_VERSION. With that change, reviewed-by: Jiewen

Re: [edk2-devel] [PATCH 0/7] CryptoPkg: Add BigNum and EC support to BaseCryptLib

2022-09-18 Thread yi1 li
Hi all, Is there any comment on this patch? Thanks. Regards, Yi -Original Message- From: devel@edk2.groups.io On Behalf Of yi1 li Sent: Wednesday, September 7, 2022 4:29 PM To: devel@edk2.groups.io Cc: Li, Yi1 ; Yao, Jiewen ; Wang, Jian J ; Xiaoyu Lu ; Jiang, Guomin Subject: [edk2-de