Re: [edk2-devel] [PATCH] UefiPayloadPkg: Provide option to use Boot Splash

2022-03-10 Thread Guo Dong
Yes, if you do it only when you could locate gEdkiiPlatformLogoProtocolGuid. This way you don’t need a PCD and the build option is only used for logo module built-in or not. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87423): https:/

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Provide option to use Boot Splash

2022-03-10 Thread Sean Rhodes
Do you mean check if the protocol exist in PlatformBootManager.c? i.e. if (gEdkiiPlatformLogoProtocolGuid ) { gST->ConOut->ClearScreen (gST->ConOut); If not, can I ask the reasoning, as if I understand it, that would be a complex solution for saving one PCD -=-=-=-=-=-=-=-=-=-=-=- Groups.io Lin

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Provide option to use Boot Splash

2022-03-09 Thread Ni, Ray
s.io Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Provide option to use Boot Splash Happy to fix the patch, just to check, with the build option? It does sound like a safer bet - even if we default it to true. Thanks Sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sen

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Provide option to use Boot Splash

2022-03-08 Thread Sean Rhodes
Happy to fix the patch, just to check, with the build option? It does sound like a safer bet - even if we default it to true. Thanks Sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87365): https://edk2.groups.io/g/devel/message/873

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Provide option to use Boot Splash

2022-03-04 Thread Guo Dong
; Ma, Maurice ; You, Benjamin Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Provide option to use Boot Splash Can you avoid introducing the PCD by always including BootLogo driver? By the way, you changed brotli version. Is that expected? -Original Message- From: devel@edk2.groups.i

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Provide option to use Boot Splash

2022-03-04 Thread Guo Dong
Please update this patch not to change MdeModulePkg/Library/BrotliCustomDecompressLib/brotli Thanks, Guo -Original Message- From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Sunday, February 20, 2022 2:34 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Rhodes, Sean ; Ni, Ray ; Ma

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Provide option to use Boot Splash

2022-02-20 Thread Ni, Ray
Can you avoid introducing the PCD by always including BootLogo driver? By the way, you changed brotli version. Is that expected? -Original Message- From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Monday, February 21, 2022 5:34 AM To: devel@edk2.groups.io Cc: Dong, Guo ; Rhodes,