Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-03-31 Thread Sheng Lean Tan
Merged: https://github.com/tianocore/edk2/pull/2596 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88303): https://edk2.groups.io/g/devel/message/88303 Mute This Topic: https://groups.io/mt/88853648/21656 Group Owner: devel+ow...@edk2.gr

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-03-07 Thread Guo Dong
@edk2.groups.io Cc: Rhodes, Sean ; Ni, Ray ; Ma, Maurice ; You, Benjamin Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable Reviewed-by: Guo Dong -Original Message- From: Sean Rhodes Sent: Saturday, March 5, 2022 3:15 AM To: devel@edk2.groups.io Cc

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-03-07 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: Sean Rhodes Sent: Saturday, March 5, 2022 3:15 AM To: devel@edk2.groups.io Cc: Rhodes, Sean ; Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin Subject: [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable Provide a build option

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-03-04 Thread Guo Dong
Could you re-send the patch without .../Library/BrotliCustomDecompressLib/brotli? Thanks, Guo From: Ni, Ray Sent: Monday, February 28, 2022 6:28 PM To: Rhodes, Sean Cc: devel@edk2.groups.io; Dong, Guo ; Ma, Maurice ; You, Benjamin Subject: RE: [PATCH] UefiPayloadPkg: Make Boot Manager Key

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-02-28 Thread Ni, Ray
Reviewed-by: Ray Ni From: Sean Rhodes Sent: Wednesday, February 23, 2022 3:22 AM To: Ni, Ray Cc: devel@edk2.groups.io; Dong, Guo ; Ma, Maurice ; You, Benjamin Subject: Re: [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable True - but the experience is better with F2 (on "normal" com

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-02-22 Thread Sean Rhodes
True - but the experience is better with F2 (on "normal" computers/non-Chromebooks). We've got a lot of feedback, and for most, people turn on their computers and start tapping Escape when they want Grub. If it's mapped, this gets intercepted by UiApp. Even if they exit, with BGRT in the equation,

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-02-21 Thread Ni, Ray
Grub runs later. Then what does “conflict” mean? From: Sean Rhodes Sent: Monday, February 21, 2022 3:48 PM To: Ni, Ray Cc: devel@edk2.groups.io; Dong, Guo ; Ma, Maurice ; You, Benjamin Subject: Re: [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable We would prefer to keep PCD, as Esc

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-02-20 Thread Sean Rhodes
We would prefer to keep PCD, as Esc can conflict with Grub on normal (not Chromebook) devices Thank you On Mon, 21 Feb 2022 at 05:26, Ni, Ray wrote: > Can you just map both ESC and F2 to the UI? So that PCD is not needed. > > Thanks, > Ray > > -Original Message- > From: Sean Rhodes > S

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-02-20 Thread Ni, Ray
Can you just map both ESC and F2 to the UI? So that PCD is not needed. Thanks, Ray -Original Message- From: Sean Rhodes Sent: Monday, February 21, 2022 5:39 AM To: devel@edk2.groups.io Cc: Dong, Guo ; Rhodes, Sean ; Ni, Ray ; Ma, Maurice ; You, Benjamin Subject: [PATCH] UefiPayloadPk

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-02-02 Thread Guo Dong
] UefiPayloadPkg: Make Boot Manager Key configurable + DEFINE PLATFORM_BOOT_TIMEOUT= 3 It looks you missed the change to gEfiMdePkgTokenSpaceGuid using PLATFORM_BOOT_TIMEOUT. Thanks, Guo -Original Message- From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Wednesday, February 2

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-02-02 Thread Guo Dong
+ DEFINE PLATFORM_BOOT_TIMEOUT= 3 It looks you missed the change to gEfiMdePkgTokenSpaceGuid using PLATFORM_BOOT_TIMEOUT. Thanks, Guo -Original Message- From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Wednesday, February 2, 2022 12:16 AM To: devel@edk2.groups.io Cc: