hi, ray looks like after only changed the title, there created another groups,
please check below link. thanks
[PATCH] Pkg-Module:UefiCpuPkg/MpLib:Do not assume BSP is #0 (groups.io) (
https://edk2.groups.io/g/devel/message/119161 )
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messa
Ning,
The patch looks good to me.
But it seems you did not change the patch title to a more specific message.
[Ray.1] The subject should be more specific. E.g.: UefiCpuPkg/MpInitLib: Do not
assume BSP is #0.
Thanks,
Ray
From: Feng, Ning
Sent: Friday, May 24,
Hi, ray,i have already update the patch as per request. run the uncrustify from
local, fixed the coding style issue.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119141): https://edk2.groups.io/g/devel/message/119141
Mute This Topic: h
Ning,
I tried to run uncrustify locally and still saw additional changes. It might
mean the code style doesn't follow the uncrustify.
more comments embedded in the patch mail starting with [Ray.].
Thanks,
Ray
From: Feng, Ning
Sent: Thursday, May 23, 2024 19:13
T
