Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] Platform/Intel: Fix invalid DEBUG() macros

2022-10-10 Thread Isaac Oram
: Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] Platform/Intel: Fix invalid DEBUG() macros Series Reviewed-by: Isaac Oram -Original Message- From: mikub...@linux.microsoft.com Sent: Tuesday, October 4, 2022 8:35 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] Platform/Intel: Fix invalid DEBUG() macros

2022-10-10 Thread Isaac Oram
Series Reviewed-by: Isaac Oram -Original Message- From: mikub...@linux.microsoft.com Sent: Tuesday, October 4, 2022 8:35 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Luo, Heng ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms][PATCH v1 0/3

Re: [edk2-devel][edk2-platforms][PATCH v1 0/3]

2022-09-09 Thread Nate DeSimone
Hi Benjamin, I have provided some comments for you on patches 2 and 3. In addition, please rebase this patch series with latest as there has been some changes since my initial patch series from June. Thanks, Nate > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Benjami

Re: [edk2-devel][edk2-platforms][PATCH V1 0/3] Update PlatformPayloadPkg to match feature conventions

2022-08-16 Thread Oram, Isaac W
Pushed as 6a847c32c0..1096b98314 Individual patches were Reviewed-by: Sai Chaganty Reviewed-by: Guo Dong -Original Message- From: devel@edk2.groups.io On Behalf Of Oram, Isaac W Sent: Wednesday, August 10, 2022 3:47 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-06-06 Thread Nate DeSimone
The series has been pushed as ~3018b1f..61af470 -Original Message- From: mikub...@linux.microsoft.com Sent: Monday, April 11, 2022 1:58 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms][PATCH v1 0/3] MinPlatformPk

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-06-06 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Monday, April 11, 2022 1:58 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty off

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-05-16 Thread Michael Kubacki
Can someone seriously respond? This was approved over 3 weeks ago and sent 5 weeks ago. I know Ankit now has a similar change out but I'd like to see if this can get in and that be rebased on it since this has been out for so long and has the primary change needed for our integration. Thanks

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-05-13 Thread Michael Kubacki
Reminder On 5/10/2022 1:34 PM, Michael Kubacki wrote: Another reminder to look at this patch. Thanks, Michael On 4/29/2022 4:07 PM, Michael Kubacki wrote: Another reminder to merge this series. Chasel has added his review and that is in this branch: https://github.com/makubacki/edk2-platfo

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-05-10 Thread Michael Kubacki
Another reminder to look at this patch. Thanks, Michael On 4/29/2022 4:07 PM, Michael Kubacki wrote: Another reminder to merge this series. Chasel has added his review and that is in this branch: https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-04-29 Thread Michael Kubacki
Another reminder to merge this series. Chasel has added his review and that is in this branch: https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1 Thanks, Michael On 4/22/2022 10:04 AM, Michael Kubacki wrote: Reminder to review this series. Ankit Si

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-04-25 Thread Michael Kubacki
Thanks Chasel. I pushed a branch rebased on the latest master branch with R-b tags here in case that helps with merging: https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcds_minplatformpkg_v1_rb1 Regards, Michael On 4/25/2022 12:08 AM, Chiu, Chasel wrote: Thanks Michael!

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-04-24 Thread Chiu, Chasel
Thanks Michael! For this patch series: Reviewed-by: Chasel Chiu > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Tuesday, April 12, 2022 4:58 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > ; Dong, Eric > Subject: [edk2-plat

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-04-22 Thread Michael Kubacki
Reminder to review this series. Ankit Sinha has reviewed it but need a maintainer to review and merge. On 4/11/2022 4:58 PM, Michael Kubacki wrote: From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543 Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consume

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-04-11 Thread Sinha, Ankit
Reviewed-by: Ankit Sinha > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Monday, April 11, 2022 1:58 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Liming > ; Dong, Eric > Subject: [edk2-devel] [edk2-platforms]

Re: [edk2-devel] [edk2-platforms][PATCH V1 0/3] Platform/Sgi: enable support for UEFI secure boot

2021-06-02 Thread Sami Mujawar
Pushed as d4fe6d9defc2..1d23831b5f07 Thanks. Regards, Sami Mujawar On 24/05/2021 06:22 PM, Sayanta Pattanayak wrote: This patch series adds secure boot support for Arm's reference design platforms. The first patch refactors the existing StandaloneMM platform description file and splits into

Re: [edk2-devel] [edk2-platforms][PATCH V1 0/3] Platform/Sgi: enable support for UEFI secure boot

2021-06-01 Thread Thomas Abraham
On 5/24/21 10:52 PM, Sayanta Pattanayak via groups.io wrote: > This patch series adds secure boot support for Arm's reference design > platforms. The first patch refactors the existing StandaloneMM platform > description file and splits into three different files. This is required > to accomodate

Re: [edk2-devel] [edk2-platforms][PATCH V1 0/3] Add FW Boot Media Device Indicator

2019-10-06 Thread Chaganty, Rangasai V
...@apple.com; devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Dong, Eric ; Gao, Liming ; Ni, Ray Subject: RE: [edk2-devel] [edk2-platforms][PATCH V1 0/3] Add FW Boot Media Device Indicator Thanks for sharing. You articulated well why I also don't think this is required in MdePkg. My description o

Re: [edk2-devel] [edk2-platforms][PATCH V1 0/3] Add FW Boot Media Device Indicator

2019-10-03 Thread Kubacki, Michael A
ps.io; Kubacki, Michael A Cc: Chaganty, Rangasai V ; Dong, Eric ; Gao, Liming ; Ni, Ray Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 0/3] Add FW Boot Media Device Indicator Since I was around back in the Intel Tiano days and I've worked on all the PI specs I can share the history.

Re: [edk2-devel] [edk2-platforms][PATCH V1 0/3] Add FW Boot Media Device Indicator

2019-10-02 Thread Andrew Fish via Groups.Io
Since I was around back in the Intel Tiano days and I've worked on all the PI specs I can share the history. The reset vector is a hardware thing. It is usually at the top or bottom of the address space. For x86 it is at the TOP of the ROM and that is why the FV has a VoluteTop file GUID that

Re: [edk2-devel] [edk2-platforms][PATCH V1 0/3] Add FW Boot Media Device Indicator

2019-10-02 Thread Kubacki, Michael A
In platforms built for boot media other than SPI flash there has been a compelling need for silicon and platform code to be aware of the firmware boot media but apart from the UEFI variable driver (which is a special case being addressed here - https://github.com/makubacki/edk2/tree/storage_agnost

Re: [edk2-devel] [edk2-platforms][PATCH V1 0/3] Add FW Boot Media Device Indicator

2019-10-02 Thread Chaganty, Rangasai V
I am not sure if there is a silicon scope around the FirmwareBootMediaLib. Have we considered adding this interface to MdePkg, instead? -Original Message- From: Kubacki, Michael A Sent: Monday, September 30, 2019 6:16 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Dong, Eric ; G