Re: [edk2-devel] iSCSI and iBFT

2019-05-23 Thread Michael Brown
On 23/05/2019 10:46, Tomas Pilar (tpilar) wrote: I was mostly puzzled by the double step. First find a parent device to LoadedImage that support NII. Rather than using that device we will scan all devices to see if any of them has the same NII protocol and if so we use that one. I am not sure

Re: [edk2-devel] iSCSI and iBFT

2019-05-23 Thread Tomas Pilar (tpilar)
I was mostly puzzled by the double step. First find a parent device to LoadedImage that support NII. Rather than using that device we will scan all devices to see if any of them has the same NII protocol and if so we use that one. I am not sure there is any advantage compared to just using the o

Re: [edk2-devel] iSCSI and iBFT

2019-05-22 Thread Michael Brown
On 22/05/2019 11:40, Tomas Pilar (tpilar) wrote: Yeah, I just AllocateCopyPool the static struct on heap for each device. I can honestly see how one would assume that a protocol instance would never be installed on more than one handle, same as I assumed that using a statically allocated struc

Re: [edk2-devel] iSCSI and iBFT

2019-05-22 Thread Tomas Pilar (tpilar)
r the description! > > What is the solution to the problem? Per-port NII structs? (I don't have > any experience with EFI_NETWORK_INTERFACE_IDENTIFIER_PROTOCOL.) > > Thanks > Laszlo > > > >> -Original Message- >> From: devel@edk2.groups.io On Behalf

Re: [edk2-devel] iSCSI and iBFT

2019-05-22 Thread Laszlo Ersek
t; To: Devel EDK2 ; Tomas Pilar > Subject: Re: [edk2-devel] iSCSI and iBFT > > On 05/21/19 16:54, Tomas Pilar (tpilar) wrote: >> I am going to commit the cardinal sin of online dev support. > > heh :) > >> 'Never mind, found the problem' > > What was

Re: [edk2-devel] iSCSI and iBFT

2019-05-22 Thread Tomas Pilar (tpilar)
; Tomas Pilar Subject: Re: [edk2-devel] iSCSI and iBFT On 05/21/19 16:54, Tomas Pilar (tpilar) wrote: > I am going to commit the cardinal sin of online dev support. heh :) > 'Never mind, found the problem' What was it? I didn't ignore your original email -- I looked

Re: [edk2-devel] iSCSI and iBFT

2019-05-21 Thread Laszlo Ersek
On 05/21/19 16:54, Tomas Pilar (tpilar) wrote: > I am going to commit the cardinal sin of online dev support. heh :) > 'Never mind, found the problem' What was it? I didn't ignore your original email -- I looked at iPXE briefly, but couldn't blame anything at once, and then I quickly ran out of

Re: [edk2-devel] iSCSI and iBFT

2019-05-21 Thread Tomas Pilar (tpilar)
I am going to commit the cardinal sin of online dev support. 'Never mind, found the problem' From: Tomas Pilar Sent: 20 May 2019 16:57 To: 'devel@edk2.groups.io' Subject: iSCSI and iBFT Hi, I have a bit of an esoteric problem. When I configure the software iscsi intiator that is part of EDK2

[edk2-devel] iSCSI and iBFT

2019-05-20 Thread Tomas Pilar (tpilar)
Hi, I have a bit of an esoteric problem. When I configure the software iscsi intiator that is part of EDK2 platform network stack, the platform network stack with install iBFT table into the ACPI tables so that the configuration can be picked up by further boot loaders and the OS. So far so goo