The tweaks look good to me.
Thanks,
Michael
On 7/9/2024 11:03 AM, Leif Lindholm wrote:
Hi Michael,
On Tue, Jul 09, 2024 at 10:44:46 -0400, Michael Kubacki wrote:
Hi Leif,
Thanks for raising this. The label was intended to be set from the PR
template which has an explanation:
https://github.
Hi Michael,
On Tue, Jul 09, 2024 at 10:44:46 -0400, Michael Kubacki wrote:
> Hi Leif,
>
> Thanks for raising this. The label was intended to be set from the PR
> template which has an explanation:
>
> https://github.com/tianocore/edk2/blob/master/.github/pull_request_template.md
>
> If the brea
Hi Leif,
Thanks for raising this. The label was intended to be set from the PR
template which has an explanation:
https://github.com/tianocore/edk2/blob/master/.github/pull_request_template.md
If the breaking change box is checked, it will be added automatically.
I added a description in Git
Hi,
I'm seeing something in several PRs in flight (and merged) that have
"impact:breaking-change" set, where the purpose of the PR is to fix said
breakage, not introduce API compatibilities.
Am I correct in my understanding that this is not the intended use, and
if so how do we address the m
