you know
> > > if there's any downsides found.
> > >
> > > On 11/16/2021 2:18 PM, Kinney, Michael D wrote:
> > > > Could we add this feature to the Uncrustify CI Plugin?
> > > >
> > > &
l@edk2.groups.io On Behalf Of Michael Kubacki
> Sent: Tuesday, November 16, 2021 3:55 PM
> To: Pedro Falcato
> Cc: edk2-devel-groups-io
> Subject: Re: [edk2-devel] Uncrustify configuration file and file/function
> templates
>
> The poc_5 branch config file is based on
> >> From: Michael Kubacki mailto:mikub...@linux.microsoft.com>
> <mailto:mikub...@linux.microsoft.com
<mailto:mikub...@linux.microsoft.com>>>
> >> Sent: Tuesday, November 16, 2021 10:54 AM
> >> To: devel@edk2.groups.io <mailt
add this feature to the Uncrustify CI Plugin?
> > >
> > > Mike
> > >
> > >> -Original Message-
> > >> From: Michael Kubacki > <mailto:mikub...@linux.microsoft.com>>
> > >> Sent: Tues
ion header that has not been filled in.
>>>
>>> Mike
>>>
>>>> -----Original Message-
>>>> From: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
mailto:devel@edk2.groups.io>> On Behalf Of
Michael Kubacki
>
> >>> One concern I have about the templates is if they get used but a
> developer
> >>> does not fill in the missing information. It would be best if a CI
> check
> >>> rejects a file/function header that has not been filled in.
> >>>
>
er 16, 2021 10:54 AM
To: devel@edk2.groups.io; Kinney, Michael D
Subject: Re: [edk2-devel] Uncrustify configuration file and file/function
templates
I would prefer to have a single version of the file if possible to
reduce synchronization issues across the two copies.
It seems that a CI plugin to
Could we add this feature to the Uncrustify CI Plugin?
Mike
> -Original Message-
> From: Michael Kubacki
> Sent: Tuesday, November 16, 2021 10:54 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Subject: Re: [edk2-devel] Uncrustify configuration file and file/functi
ssage-
From: devel@edk2.groups.io On Behalf Of Michael Kubacki
Sent: Tuesday, November 16, 2021 10:25 AM
To: devel@edk2.groups.io; Kinney, Michael D
Subject: Re: [edk2-devel] Uncrustify configuration file and file/function
templates
Hi Mike,
Those were just disabled because I typically run a sep
alf Of Michael Kubacki
> Sent: Tuesday, November 16, 2021 10:25 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Subject: Re: [edk2-devel] Uncrustify configuration file and file/function
> templates
>
> Hi Mike,
>
> Those were just disabled because I typically run a separate i
Hi Mike,
Those were just disabled because I typically run a separate invocation
of Uncrustify with them enabled to isolate code which is missing
file/function headers. My thought was the templates are helpful but we
would need to individually identify where they are placed to file TCBZs
for m
Hi Michael,
In your POC branch (https://github.com/makubacki/edk2/tree/uncrustify_poc_5), I
see the
uncrustify.cfg configuration file in the root.
https://github.com/makubacki/edk2/blob/uncrustify_poc_5/uncrustify.cfg
However, in your Wiki, you provide examples where this configuration fil
12 matches
Mail list logo
