Re: [edk2-devel] Role of DLINK2_FLAGS and link-time option consistency

2023-04-15 Thread Marvin Häuser
> On 7. Apr 2023, at 14:00, Ard Biesheuvel wrote: > > (cc Ray) > > On Fri, 7 Apr 2023 at 13:05, Marvin Häuser wrote: >> >> >> On 7. Apr 2023, at 13:02, Ard Biesheuvel wrote: >> >> IIRC DLINK2_FLAGS is mainly being used (in the GCC case) for passing >> options that need to come after previo

Re: [edk2-devel] Role of DLINK2_FLAGS and link-time option consistency

2023-04-07 Thread Ard Biesheuvel
(cc Ray) On Fri, 7 Apr 2023 at 13:05, Marvin Häuser wrote: > > > On 7. Apr 2023, at 13:02, Ard Biesheuvel wrote: > > IIRC DLINK2_FLAGS is mainly being used (in the GCC case) for passing > options that need to come after previous occurrences of the same > option with a different value, in order f

Re: [edk2-devel] Role of DLINK2_FLAGS and link-time option consistency

2023-04-07 Thread Marvin Häuser
> On 7. Apr 2023, at 13:02, Ard Biesheuvel wrote: > > IIRC DLINK2_FLAGS is mainly being used (in the GCC case) for passing > options that need to come after previous occurrences of the same > option with a different value, in order for the DLINK2 one to take > precedence. Thanks for the quick r

Re: [edk2-devel] Role of DLINK2_FLAGS and link-time option consistency

2023-04-07 Thread Ard Biesheuvel
On Fri, 7 Apr 2023 at 12:14, Marvin Häuser wrote: > > Good day everyone, > > I've been asked to check the following patch: > https://edk2.groups.io/g/devel/message/102168 > > One thing I noticed was that -no-pie is added to DLINK2_FLAGS, not > DLINK_FLAGS. For MSVC toolchains, DLINK2_FLAGS is us

[edk2-devel] Role of DLINK2_FLAGS and link-time option consistency

2023-04-07 Thread Marvin Häuser
Good day everyone, I've been asked to check the following patch: https://edk2.groups.io/g/devel/message/102168 One thing I noticed was that -no-pie is added to DLINK2_FLAGS, not DLINK_FLAGS. For MSVC toolchains, DLINK2_FLAGS is used for a separate linker step [1] introduced by [2], which makes