Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs

: scott.wigin...@hpe.com Sent: Monday, October 21, 2019 6:12 AM To: Kinney, Michael D ; devel@edk2.groups.io Subject: Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs Michael, Wouldn't the current implementation ASSERT if there are different plug-in cards by the same vendor using the same GU

Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs

Michael, Wouldn't the current implementation ASSERT if there are different plug-in cards by the same vendor using the same GUID in their FMP?  They are managing different hardware and have no knowledge of the existence of the other FMP instance.  Each FMP is only aware of the specific device on

Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs

changes to EsrtFmp causing ASSERTs Hi Michael, I'm not sure that I agree with your last statement. The says that HardwareInstance is "Only present in version 3 or higher" in reference to the EFI_FIRMWARE_IMAGE_DESCRIPTOR. Isn't that the point of the DescriptorV

Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs

Hi Michael, I'm not sure that I agree with your last statement.  The says that HardwareInstance is "Only present in version 3 or higher" in reference to the  EFI_FIRMWARE_IMAGE_DESCRIPTOR.  Isn't that the point of the DescriptorVersion parameter in FMP.GetImageInfo?  To know if that field is eve

Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs

higher. Mike From: Spottswood, Jason Sent: Tuesday, October 1, 2019 2:21 PM To: Kinney, Michael D ; devel@edk2.groups.io; Rothman, Michael A Subject: RE: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs Hey Mike, Specifically, my team has run into ASSERTs on systems loaded with many

Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs

.groups.io; Spottswood, Jason ; Rothman, Michael A ; Kinney, Michael D Subject: RE: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs Hi Jason, I believe the logic to check for uniqueness of FMP Descriptor is correct. The UEFI Spec has 2 structs with HardwareInstance. One is FMP Descriptor and

Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs

Behalf Of Spottswood, Jason Sent: Monday, September 30, 2019 2:24 PM To: Rothman, Michael A ; devel@edk2.groups.io Subject: Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs Cut-n-paste problem. My apologies. Copying again in plain text: // // Check to see of FmpImageInfoBuf GUID

Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs

Jason/Mike, What would you propose is done if the hw instance in 0 but an entry with same guid and instance 0 already exists? Ignore it and first in wins? It asserts because i am not aware of the right answer for the ESRT and it creates a situation with unpredictable results for capsule process

Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs

September 30, 2019 3:53 PM To: devel@edk2.groups.io; Spottswood, Jason Subject: Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs Jason, Agreed - though that image you sent was challenging for these old eyes. Black on dark grey? Ack! Thanks, Michael A. Rothman -

Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs

Jason, Agreed - though that image you sent was challenging for these old eyes. Black on dark grey? Ack! Thanks, Michael A. Rothman --- Let no excuse be a barrier to your success. On Sep 30, 2019, at 1:48 PM, "jason.spottsw...@hpe.com

[edk2-devel] Recent changes to EsrtFmp causing ASSERTs

In EsrtFmp.c, function CreateEsrtEntry, line 196, the code asserts if the FMP image hardware instance matches that of an existing instance.  This is fine if the hardware instance is supported.  The field is optional though.  In the UEFI spec, "a zero hardware instance means the FMP provider is n