Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

2020-07-07 Thread Liming Gao
t: Re: [edk2-devel] License Check - was OvmfPkg: Adding support for > bhyve as OvmfPkg/Bhyve > > On 07/03/20 03:40, Gao, Liming wrote: > > > Besides, there is another new checker of ECC to check coding style for each > > patch. Can you give your comment? > > https:/

Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

2020-07-03 Thread Laszlo Ersek
On 07/03/20 03:40, Gao, Liming wrote: > Besides, there is another new checker of ECC to check coding style for each > patch. Can you give your comment? > https://edk2.groups.io/g/devel/message/61966 I've seen that feature. Importantly, it gives package maintainers package-level exception lists.

Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

2020-07-03 Thread Liming Gao
-devel] License Check - was OvmfPkg: Adding support for > bhyve as OvmfPkg/Bhyve > > On Fri, Jul 03, 2020 at 01:40:26 +, Gao, Liming wrote: > > > >>> *Reads patch* > > > >>> *Figuratively spits coffee all over keyboard* > > > >>&g

Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

2020-07-03 Thread Leif Lindholm
On Fri, Jul 03, 2020 at 01:40:26 +, Gao, Liming wrote: > > >>> *Reads patch* > > >>> *Figuratively spits coffee all over keyboard* > > >>> > > >>> No, this is not OK. > > >>> > > >>> We *STILL* have no agreed process for accepting non bsd+patent content > > >>> since we dropped the contribution

Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

2020-07-02 Thread Liming Gao
Michael D > Subject: Re: [edk2-devel] License Check - was OvmfPkg: Adding support for > bhyve as OvmfPkg/Bhyve > > On 7/2/20 4:13 PM, Leif Lindholm via groups.io wrote: > > On Thu, Jul 02, 2020 at 13:49:45 +, Gao, Liming wrote: > >> Leif: > >> > >

Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

2020-07-02 Thread Ard Biesheuvel
-io ; Ard Biesheuvel ; Andrew Fish ; Justen, Jordan L ; Kinney, Michael D Subject: Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve On Thu, Jul 02, 2020 at 11:27:25 +0200, Laszlo Ersek wrote: This likely comes from BaseTools commit a4cfb842fca9 ("Base

Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

2020-07-02 Thread Leif Lindholm
evel-groups-io > > ; Ard Biesheuvel ; > > Andrew Fish ; Justen, Jordan L > > ; Kinney, Michael D > > Subject: Re: [edk2-devel] License Check - was OvmfPkg: Adding support for > > bhyve as OvmfPkg/Bhyve > > > > On Thu, Jul 02, 2020 at 11:27:25 +0200,

Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

2020-07-02 Thread Liming Gao
D > Subject: Re: [edk2-devel] License Check - was OvmfPkg: Adding support for > bhyve as OvmfPkg/Bhyve > > On Thu, Jul 02, 2020 at 11:27:25 +0200, Laszlo Ersek wrote: > > This likely comes from BaseTools commit a4cfb842fca9 > > ("BaseTools/PatchCheck.py: Add License

Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

2020-07-02 Thread Leif Lindholm
On Thu, Jul 02, 2020 at 11:27:25 +0200, Laszlo Ersek wrote: > This likely comes from BaseTools commit a4cfb842fca9 > ("BaseTools/PatchCheck.py: Add LicenseCheck", 2020-06-12). > > One approach would be to remove "VbeShim.h" from the tracked files under > OvmfPkg, replacing it with a PREBUILD comma