Re: [edk2-devel] I think we need a Panic API...

2022-02-10 Thread Andrew Fish via groups.io
022 11:37 AM > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Ni, Ray > mailto:ray...@intel.com>>; 'Andrew Fish' <mailto:af...@apple.com>> > Subject: Re: [edk2-devel] I think we need a Panic API... > > Ray, > > EFI_SYSTEM_CONTEXT was de

Re: [edk2-devel] I think we need a Panic API...

2022-02-09 Thread Ni, Ray
lt;mailto:af...@apple.com>; edk2-devel-groups-io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] I think we need a Panic API... Andrew, I agree Panic is useful because ASSERT is a NOP in the release build. Can you explain a bit more on ProcessSystemContext? -Original Messag

Re: [edk2-devel] I think we need a Panic API...

2022-02-09 Thread Jeff Fan
Ray, EFI_SYSTEM_CONTEXT was defined in MdePkg/Include/Protocol/DebugSupport.h Jeff fanjianf...@byosoft.com.cn From: Ni, Ray Date: 2022-02-10 10:54 To: Andrew Fish; edk2-devel-groups-io Subject: Re: [edk2-devel] I think we need a Panic API... Andrew, I agree Panic is useful because ASSERT is

Re: [edk2-devel] I think we need a Panic API...

2022-02-09 Thread Ni, Ray
Andrew, I agree Panic is useful because ASSERT is a NOP in the release build. Can you explain a bit more on ProcessSystemContext? -Original Message- From: Andrew Fish Sent: Thursday, February 3, 2022 12:37 PM To: edk2-devel-groups-io Cc: Ni, Ray Subject: I think we need a Panic API..

Re: [edk2-devel] I think we need a Panic API...

2022-02-03 Thread Michael D Kinney
condition. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Andrew Fish > via groups.io > Sent: Wednesday, February 2, 2022 8:37 PM > To: edk2-devel-groups-io > Cc: Ni, Ray > Subject: [edk2-devel] I think we need a Panic API... > > Mike Kinney

[edk2-devel] I think we need a Panic API...

2022-02-02 Thread Andrew Fish via groups.io
Mike Kinney mentioned at the TianoCore Stewards Meeting that it might be a good idea to add a panic API to the edk2. I agree. Some background…. While ASSERT is a powerful tool I think we have a tendency to misuse it at times in our TianoCore code: 1) Sometime we do ASSERT when we should be erro