OK. Thanks.
I just noticed my local repo is still in devel-minplatform branch.
Thanks,
Bob
-Original Message-
From: Bi, Dandan
Sent: Thursday, July 4, 2019 8:55 AM
To: Feng, Bob C ; Gao, Liming ;
devel@edk2.groups.io
Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
H
Hi Bob,
I have updated GitEdk2MinMtOlympus.bat for minpurely via
https://github.com/tianocore/edk2-platforms/commit/e7fc97a3f9045c35a077ab0151c696aeba722417
And GitEdk2MinKabylake.bat for minkabylake has been removed via
https://github.com/tianocore/edk2-platforms/commit/acbd81a92de1b4213f272a2
Hi Dandan,
I found the GitEdk2MinMtOlympus.bat for minpurely and GitEdk2MinKabylake.bat
for minkabylake need to update. Would you update it?
Thanks,
Bob
-Original Message-
From: Gao, Liming
Sent: Friday, June 28, 2019 9:12 AM
To: Bi, Dandan ; Feng, Bob C ;
devel@edk2.groups.io
Subject
vel@edk2.groups.io
>Subject: Re: [edk2-devel] [patch 0/2] Edk2Setup: Enahnce edk2setup batch
>files
>
>Dandan:
>
> If you find any pre script to use --nt32 option, please remove them first,
> then
>do this change.
>
>>-Original Message-
>>From: Bi, Danda
Dandan:
If you find any pre script to use --nt32 option, please remove them first,
then do this change.
>-Original Message-
>From: Bi, Dandan
>Sent: Friday, June 28, 2019 9:11 AM
>To: Gao, Liming ; Feng, Bob C
>; devel@edk2.groups.io
>Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setu
Hi Liming and Bob,
Thanks for the review. So we reach the agreement that remove the --nt32 flag,
right? If so, I will address Liming's comments and then push these two patches.
Thanks,
Dandan
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, June 27, 2019 11:17 PM
> To: Feng,
Yes. Those script needs to be updated together.
> -Original Message-
> From: Feng, Bob C
> Sent: Thursday, June 27, 2019 11:14 PM
> To: Gao, Liming ; Bi, Dandan ;
> devel@edk2.groups.io
> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
> OK. I think it may break som
OK. I think it may break some pre-build script if the pre-build script have
"edksetup --nt32"...
-Original Message-
From: Gao, Liming
Sent: Thursday, June 27, 2019 10:48 PM
To: Feng, Bob C ; Bi, Dandan ;
devel@edk2.groups.io
Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch f
Bob:
--nt32 option is added for Nt32Pkg. Now, Nt32Pkg has been removed. So, I
think it is fine to remove --nt32 option.
> -Original Message-
> From: Feng, Bob C
> Sent: Thursday, June 27, 2019 7:56 PM
> To: Bi, Dandan ; devel@edk2.groups.io
> Cc: Gao, Liming
> Subject: RE: [patch 0/2]
The patches look good.
I think removing --nt32 option is incompatible change. What about keep the
--nt32 ?
For the Patch 2 setup for different VS tool chains.
Reviewed-by: Bob Feng
Thanks,
Bob
-Original Message-
From: Bi, Dandan
Sent: Sunday, June 23, 2019 9:59 PM
To: devel@edk2.grou
Dandan:
One minor comment. Help message shows two ForceRebuild options. Please remove
one. And, this change retire --nt32 option. Please update wiki page on edksetup
usage in
https://github.com/tianocore/tianocore.github.io/wiki/Getting-Started-Writing-Simple-Application.
With those change, R
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693
Patch 1 remove nt32 related flags in bat files.
Patch 2 setup for different VS tool chains.
Cc: Bob Feng
Cc: Liming Gao
Dandan Bi (2):
Edk2: Remove nt32 related flag in bat files
Edk2Setup: Support different VS tool chain setup
Base
12 matches
Mail list logo
