devel@edk2.groups.io; Kinney, Michael D
Cc: Xue, Gavin ; suni...@ventanamicro.com; Warkentin,
Andrei ; Wang, Yimin ; Sheng,
Alan
Subject: Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol
define for RISCV64
On Fri, Jun 30, 2023 at 5:59 PM Michael D Kinney
wrote:
>
> Usi
; Pedro Falcato
Cc: suni...@ventanamicro.com; Warkentin, Andrei ;
Wang, Yimin ; Sheng, Alan ; Kinney,
Michael D
Subject: RE: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol
define for RISCV64
Using the same include guard define name is preferred.
Why was anything other than
On Fri, Jun 30, 2023 at 5:59 PM Michael D Kinney
wrote:
>
> Using the same include guard define name is preferred.
>
> Why was anything other than that considered?
I don't see the point of making the include guard an actual part of
the "API". Consumers should not depend on it being named $WHATEVE
.@ventanamicro.com; Warkentin, Andrei
> ; Wang, Yimin ;
> Sheng, Alan
> Subject: RE: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind
> symbol define for RISCV64
>
> Hi Mike,
>
> Thanks for your comments.
> I haven't seen specific error message when using the
t: RE: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol
define for RISCV64
It is better if we can use the same include guard names, but is not
strictly required for builds to work.
What is the specific error message seen when using the same include guard
names as other CPU types?
In
21, 2023 10:16 PM
> To: Xue, Gavin
> Cc: devel@edk2.groups.io; suni...@ventanamicro.com; Warkentin, Andrei
> ; Wang, Yimin ; Sheng,
> Alan
> Subject: Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind
> symbol define for RISCV64
>
> On Fri, Jun 16, 2023 at
al Message-
From: Pedro Falcato
Sent: Wednesday, June 21, 2023 10:16 PM
To: Xue, Gavin
Cc: devel@edk2.groups.io; suni...@ventanamicro.com; Warkentin, Andrei
; Wang, Yimin ; Sheng, Alan
Subject: Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol
define for RISCV64
On Fri, Jun 1
On Thu, Jun 22, 2023 at 10:59 AM Xue, Gavin wrote:
>
> Hi Pedro,
>
> Thanks for your feedback.
>
> The sample code what I listed in last mail is from/owned by another team, and
> I didn't find other special #ifndef case for RSIC-V building so far.
> RISC-V is an new processor architecture in edk2
On Fri, Jun 16, 2023 at 4:52 PM Xue, Gavin wrote:
>
> Hi Sunil/Pedro,
>
> 1. As you know, ProcessorBind.h file of CPU Architecture file declares sets
> of base types for edk2 code compiling.
> So data type in edk2 code doesn't rely on specific compiler (msvc, gcc etc.),
> which is a good design.
rds,
Gavin
-Original Message-
From: Pedro Falcato
Sent: Friday, June 16, 2023 10:12 PM
To: devel@edk2.groups.io; suni...@ventanamicro.com
Cc: Xue, Gavin ; Warkentin, Andrei
; Wang, Yimin ; Sheng, Alan
Subject: Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol
Different symbol (PROCESSOR_BIND_H__) define in RISCV64 ProcessorBinding.h
from other CPU Arch. An unexception compilation error generated
if include __PROCESSOR_BIND_H__ symbol in header file for
cross-platform compiling.
Cc: Andrei Warkentin
Cc: Sunil V L
Cc: Yimin Wang
Cc: Alan Sheng
Signed
On Fri, Jun 16, 2023 at 11:36 AM Sunil V L wrote:
>
> On Fri, Jun 16, 2023 at 03:22:57PM +0800, Gavin Xue wrote:
> > Different symbol (PROCESSOR_BIND_H__) define in RISCV64 ProcessorBinding.h
> > from other CPU Arch. An unexception compilation error generated
> > if include __PROCESSOR_BIND_H__ sy
On Fri, Jun 16, 2023 at 03:22:57PM +0800, Gavin Xue wrote:
> Different symbol (PROCESSOR_BIND_H__) define in RISCV64 ProcessorBinding.h
> from other CPU Arch. An unexception compilation error generated
> if include __PROCESSOR_BIND_H__ symbol in header file for
> cross-platform compiling.
>
> Cc:
13 matches
Mail list logo
