Re: [edk2-devel] [edk2-platforms] [PATCH 1/5] BoardModulePkg: Add bios info HOB

2019-10-07 Thread Kubacki, Michael A
Library/BiosInfo.h: 1. I think the file description can be more accurate and useful than "Driver for BIOS Info support." This header file is not a driver or restricted to any particular driver in this location. I would generalize the comment. 2. This file is not related to a library

Re: [edk2-devel] [edk2-platforms] [PATCH 1/5] BoardModulePkg: Add bios info HOB

2019-10-07 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Agyeman, Prince Sent: Thursday, October 3, 2019 2:13 PM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Desimone, Nathaniel L ; Kubacki, Michael A Subject: [edk2-platforms] [PATCH 1/5] BoardModulePkg: Add bios info HOB Added gBiosInfoG

[edk2-devel] [edk2-platforms] [PATCH 1/5] BoardModulePkg: Add bios info HOB

2019-10-03 Thread Agyeman, Prince
Added gBiosInfoGuid to be used to publish BIOS information HOB which is needed in FIT generation Also added the Bios Info header file BiosInfo.h Cc: Ankit Sinha Cc: Nate DeSimone Cc: Kubacki Michael A Signed-off-by: Prince Agyeman --- .../Intel/BoardModulePkg/BoardModulePkg.dec | 3 + ..