Re: [edk2-devel] [edk2-platforms][PATCH v3 06/41] IntelSiliconPkg: Add PCH SPI PPI

2021-06-24 Thread Michael Kubacki
Hi Sai, That sounds fine to me. I'll send it in a v4 soon. Thanks, Michael On 6/24/2021 5:56 PM, Chaganty, Rangasai V wrote: Hi Michael, Since there is a change in SPI protocol/PPI services (enum to EFI_GUID type for Flash region types), perhaps defining a new GUID would be better, just to ma

Re: [edk2-devel] [edk2-platforms][PATCH v3 06/41] IntelSiliconPkg: Add PCH SPI PPI

2021-06-24 Thread Chaganty, Rangasai V
Hi Michael, Since there is a change in SPI protocol/PPI services (enum to EFI_GUID type for Flash region types), perhaps defining a new GUID would be better, just to make sure there are no collisions. Do you see any downside to it? Regards, Sai -Original Message- From: mikub...@linux.

[edk2-devel] [edk2-platforms][PATCH v3 06/41] IntelSiliconPkg: Add PCH SPI PPI

2021-06-17 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 This SPI PPI definition is intended to serve as the single definition for Intel platform and silicon packages. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Sili