Re: [edk2-devel] [edk2-platforms][PATCH V1 00/49] Intel Advanced Feature Refactor

2019-11-27 Thread Kubacki, Michael A
Yes, I reordered the patch series this way in V2 and I will update the closed source platforms before the old advanced feature dependencies are removed. Thanks, Michael > -Original Message- > From: Bi, Dandan > Sent: Monday, November 18, 2019 12:41 AM > To: Kubacki, Michael A ; > devel@

Re: [edk2-devel] [edk2-platforms][PATCH V1 00/49] Intel Advanced Feature Refactor

2019-11-18 Thread Dandan Bi
Hi Michael, One minor comment, could we add the features into Features/ folder firstly and then update consumer platforms if have (open platforms and close source platforms) to use the ones in the new location, at last delete the old ones in Platform/Intel folder? Thanks, Dandan > -Origi

Re: [edk2-devel] [edk2-platforms][PATCH V1 00/49] Intel Advanced Feature Refactor

2019-11-15 Thread Nate DeSimone
Hi Michael, I have completed reviewing your considerably large patch series. Overall, I have approved 80% of your patches without modification. I do have feedback for 10 of the patches however. In the interest of efficiency, please reuse my "Reviewed-by" for 39 patches that I have already appro

[edk2-devel] [edk2-platforms][PATCH V1 00/49] Intel Advanced Feature Refactor

2019-11-12 Thread Kubacki, Michael A
RFC:https://edk2.groups.io/g/devel/message/49880 This patch series introduces a consistent design for Intel advanced features. Advanced features in this context refer to the definition stated in the EDK II Minimum Platform specification. Information regarding this feature design is provided in Fe