[edk2-devel] [RFC PATCH 08/28] MdePkg/BaseLib: Implement the VMGEXIT support

2019-08-20 Thread Lendacky, Thomas
From: Tom Lendacky VMGEXIT is a new instruction used for Hypervisor/Guest communication when running as an SEV-ES guest. A VMGEXIT will cause an automatic exit (AE) to occur, resulting in a #VMEXIT with an exit code value of 0x403. To support VMGEXIT, define the VMGEXIT assember routine to issue

Re: [edk2-devel] [RFC PATCH 08/28] MdePkg/BaseLib: Implement the VMGEXIT support

2019-08-20 Thread Lendacky, Thomas
Hi Ray, On 8/19/19 4:47 PM, Ni, Ray wrote: > Tom, > 1. It's not a common practice to have static inline functions defined in > header file. Who is going to call them? The functions are called from two locations, so that's why I made them static inline. I'm new to EDK2 programming, so I'm sure th

Re: [edk2-devel] [RFC PATCH 08/28] MdePkg/BaseLib: Implement the VMGEXIT support

2019-08-19 Thread Ni, Ray
Tom, 1. It's not a common practice to have static inline functions defined in header file. Who is going to call them? 2. Recently I made a change to move the AMD registers definitions to MdePkg/Include/Register/Amd from UefiCpuPkg. Do you think that's a good idea and can you please put your new