Re: [edk2-devel] [Patch v2 00/12] Add gmock support for host-based unit testing

2023-04-07 Thread Michael D Kinney
Wang, Jian J > ; Gao, Liming ; Liu, > Zhiguang ; Yao, Jiewen > ; Sean Brogan ; Andrew Fish > ; Leif Lindholm > ; Johnson, Chris N > Subject: [edk2-devel] [Patch v2 00/12] Add gmock support for host-based unit > testing > > REF: https://bugzilla.tianocore.org/show_bug.c

Re: [edk2-devel] [Patch v2 00/12] Add gmock support for host-based unit testing

2023-04-05 Thread Oliver Smith-Denny
Thanks for sending this out, looks to be a pretty clean unit testing interface. We are testing this now with some of our unit tests and will update with any feedback. In the meantime, for the patchset: Reviewed-by: Oliver Smith-Denny On 4/4/2023 11:22 AM, Michael D Kinney wrote: REF: https://

[edk2-devel] [Patch v2 00/12] Add gmock support for host-based unit testing

2023-04-04 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4389 PR: https://github.com/tianocore/edk2/pull/4180 Branch: https://github.com/mdkinney/edk2/tree/Bug_4389_UnitTestFrameworkPkg_AddGoogleMockSupport New in v2 == * SecurityPkg: Add unit test descriptions to SecureBootVariableLibGoogleT