Re: [edk2-devel] [Patch V2] MinPlatformPkg: Check if Acpi table is already installed.

2021-12-13 Thread Nate DeSimone
PM To: devel@edk2.groups.io; Desimone, Nathaniel L ; Sravanthi, K KavyaX Cc: Chiu, Chasel ; Liming Gao ; Dong, Eric ; Oram, Isaac W ; Michael Kubacki Subject: RE: [edk2-devel] [Patch V2] MinPlatformPkg: Check if Acpi table is already installed. Nate, I don't consider it as a hack. Uefi

Re: [edk2-devel] [Patch V2] MinPlatformPkg: Check if Acpi table is already installed.

2021-12-07 Thread Ni, Ray
ps.io On Behalf Of Nate DeSimone Sent: Wednesday, December 8, 2021 10:06 AM To: Sravanthi, K KavyaX ; devel@edk2.groups.io Cc: Chiu, Chasel ; Liming Gao ; Dong, Eric ; Oram, Isaac W ; Michael Kubacki Subject: Re: [edk2-devel] [Patch V2] MinPlatformPkg: Check if Acpi table is already installed.

Re: [edk2-devel] [Patch V2] MinPlatformPkg: Check if Acpi table is already installed.

2021-12-07 Thread Nate DeSimone
This seems like a hack to me. One of the major goals of the Minimum Platform Architecture is consistency. A board override for the MinPlatform provided installation of the MCFG table runs counter to that goal. Every field in the MCFG table produced by MinPlatform's implementation is fully custom

Re: [edk2-devel] [Patch V2] MinPlatformPkg: Check if Acpi table is already installed.

2021-12-06 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Sravanthi, K KavyaX Sent: Monday, December 6, 2021 2:16 PM To: devel@edk2.groups.io Cc: Sravanthi, K KavyaX ; Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [Patch V2] MinPlatformPkg: Check if Acpi table is alr

Re: [edk2-devel] [Patch V2] MinPlatformPkg: Check if Acpi table is already installed.

2021-12-06 Thread Ni, Ray
Reviewed-by: Ray Ni -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84445): https://edk2.groups.io/g/devel/message/84445 Mute This Topic: https://groups.io/mt/87535133/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk

[edk2-devel] [Patch V2] MinPlatformPkg: Check if Acpi table is already installed.

2021-12-05 Thread kavya
Check if Acpi table is already installed by locating the first ACPI table in XSDT/RSDT based on Signature Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: kavya Reviewed-by: Zhiguang Liu --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 18