Re: [edk2-devel] [Patch 1/1] BaseTools: Fix a bug of genffs command generation

2019-10-13 Thread Bob Feng
Pushed at a1f94045ffe9218ec438c4d23980de4243d21cd0 -Original Message- From: Gao, Liming Sent: Saturday, October 12, 2019 2:04 PM To: Feng, Bob C ; devel@edk2.groups.io Subject: RE: [Patch 1/1] BaseTools: Fix a bug of genffs command generation Bob: I think this version patch is correct,

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix a bug of genffs command generation

2019-10-11 Thread Liming Gao
Bob: I think this version patch is correct, because this case uses the different command in Makefile instead of the different syntax. The command 'test' depends on batch environment. It is only available in bash, not in ms-dos. So, the check condition should be OS instead of make command. Re

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix a bug of genffs command generation

2019-09-28 Thread Liming Gao
Bob: Can BaseTools base on make command to generate Makefile? The different make command will use the different Makefile type. Thanks Liming >-Original Message- >From: Feng, Bob C >Sent: Friday, September 27, 2019 10:30 AM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subj

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix a bug of genffs command generation

2019-09-27 Thread Philippe Mathieu-Daudé
On 9/27/19 4:30 AM, Bob Feng wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2221 > > The command used by multiple thread genffs feature in makefile > for testing if file exist is generated based on the toolchain family. > It should be based on the OS type. > > Cc: Liming Gao > Sign

[edk2-devel] [Patch 1/1] BaseTools: Fix a bug of genffs command generation

2019-09-26 Thread Bob Feng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2221 The command used by multiple thread genffs feature in makefile for testing if file exist is generated based on the toolchain family. It should be based on the OS type. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/Ge