Thanks Mike. Agree with you.
For the series, Acked-by: Jiewen Yao
Just FYI: I have merged rest pending CryptoPkg patches.
Please rebase when you submit next version.
Thank you
Yao Jiewen
> -Original Message-
> From: Kinney, Michael D
> Sent: Wednesday, October 12, 2022 10:23 AM
> To:
Hi Jiewen,
comments below.
Mike
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, October 11, 2022 7:07 PM
> To: Kinney, Michael D ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, Xiaoyu1 ;
> Jiang, Guomin ; Zurcher,
> Christopher ; Rebecca Cran
> ; Ard Biesheuvel
> Subject: R
> Cc: Wang, Jian J ; Lu, Xiaoyu1
> ; Jiang, Guomin ;
> Zurcher, Christopher ; Rebecca Cran
> ; Ard Biesheuvel
> Subject: Re: [edk2-devel] [Patch 00/12] CryptoPkg: Remove EC PCD and
> merge perf opt OpensslLibs
>
> OK. That means we need manual write a wrapper for all E
OK. That means we need manual write a wrapper for all EC APIs in Openssl Lib
for internal usage.
More precisely, a wrapper for the delta between OpensslLib and OpensslLibFull,
right?
There will be size difference between those two solutions, because the code
other than EC will be include in the
Jiewen,
The BKM is to just call the EC services from the layers above OpensslLib.
The EC APIs will always be present. Either real EC service or Null EC service.
This way we can remove all the #ifdef on EC PCD.
Platform developers select the OpensslLib instance with EC (OpensslLibFull.inf)
or
wi
Hi Mike
For PcdOpensslEcEnabled, I am seeing other usage. For example:
https://github.com/qizhangz/edk2/blob/EC_Upstream/CryptoPkg/Library/BaseCryptLib/Pem/CryptPem.c#L156
I think we may need BKM on "how to disable EC".
Thank you
Yao, Jiewen
> -Original Message-
> From: Kinney, Michael
Hi Jiewen,
Comments below.
Mike
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, October 11, 2022 6:09 PM
> To: Kinney, Michael D ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, Xiaoyu1 ;
> Jiang, Guomin ; Zurcher,
> Christopher ; Rebecca Cran
> ; Ard Biesheuvel
> Subject: R
Thank you Mike.
1) I like the idea to combine multiple OpensslLibIA32/X64.inf into one
OpensslLibAccel.inf.
Also the cleanup looks good to me.
2) I also like the summary in readme in
https://github.com/mdkinney/edk2/tree/CryptoPkg_RemoveEcPcd_MergeOptimizedOpensslLibs/CryptoPkg
I notice some al
The recent addition of the Ecliptic Curve (EC) feature and the performance
optimization features increased the complexity for platforms to integrate
and enable these features. This series simplifies the platform configuration
as much as possible and improves the ability to manage the the size impac
