> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Pedro Falcato
> Sent: Thursday, August 5, 2021 3:50 PM
> To: Kinney, Michael D ; devel@edk2.groups.io
> Cc: Leif Lindholm ; Bret Barkelew
>
> Subject: Re: [edk2-devel] [Patch 0/3] Ext4Pkg: Add
Hi Mike,
Thanks for the helpful pointers. I'll consider everything for V2,
which I'll submit as soon as possible (hopefully tomorrow).
RE: Code style. I'll re-run ECC and try to solve the issues. One thing
though: Is it possible to make an exception for the naming of
ext4-specific struct members?
Hi Pedro,
1) Ext4Pkg/Ext4Dxe/Ext4Dxe.inf:
* To be consistent with other drivers, BASE_NAME should be changed from Ext4
to Ext4Dxe.
* For proper dependency checking in incremental builds, please add the .h
files to the [Sources] section
Ext4Disk.h
Ext4Dxe.h
2) There are a num
Hi Pedro,
There is a build failure when building the Ext4Pkg.dsc file for a missing
RegisterFilerLib mapping.
The correct fix for this issue is to add the following !include statement to
the DSC file after the
the [Defines] section.
!include MdePkg/MdeLibs.dsc.inc
With this one change, the X6
Hi Pedro,
When I run BaseTools/Scripts/Patchcheck.py on this patch series, I see the
following issues:
Checking git commit: 5f0db07586
Ext4Pkg: Add Ext4Dxe driver.
The commit message format passed all checks.
Code format is not valid:
* EFI_D_ERROR was used, but DEBUG_ERROR is now recommended
This patch-set adds Ext4Pkg, a package designed to hold various drivers and
utilities related to the EXT4 filesystem.
Right now, it holds a single read-only UEFI EXT4 driver (Ext4Dxe), which
consumes the
DISK_IO, BLOCK_IO and DISK_IO2 protocols and produce EFI_FILE_PROTOCOL and
EFI_SIMPLE_FILE_SY
