Re: [edk2-devel] [Patch 0/2] Address C++ keyword collisions

2023-05-30 Thread Michael D Kinney
Hi Pedro, Great point on bisect. It is also important to provide patches that allow downstream usage of these fields to be able to use a subset of the patches that support both field names so they can update and test their code before using the full patch series that removes the old field name.

Re: [edk2-devel] [Patch 0/2] Address C++ keyword collisions

2023-05-30 Thread Pedro Falcato
On Mon, May 29, 2023 at 6:06 PM Michael D Kinney wrote: > > Update Tpm12.h and Tpm20.h and not use c++ reserved keywords > operator and xor in C structures to support use of these > include files when building with a C++ compiler. > > Update SecurityPkg Tpm2CommandLib to use updated field names. >

[edk2-devel] [Patch 0/2] Address C++ keyword collisions

2023-05-29 Thread Michael D Kinney
Update Tpm12.h and Tpm20.h and not use c++ reserved keywords operator and xor in C structures to support use of these include files when building with a C++ compiler. Update SecurityPkg Tpm2CommandLib to use updated field names. * Change operator -> Operator * Change xor -> Xor NOTE: This is a