Re: [edk2-devel] [Patch] MdePkg/BaseSafeIntLib: Fix VS20xx IA32 link failures

2020-02-12 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Kinney, Michael D > Sent: Thursday, February 13, 2020 6:45 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Sean Brogan > ; Bret Barkelew > Subject: [Patch] MdePkg/BaseSafeIntLib: Fix VS20xx IA32 link failures > > https://bugzilla.

[edk2-devel] [Patch] MdePkg/BaseSafeIntLib: Fix VS20xx IA32 link failures

2020-02-12 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2525 SafeUint64Mult() looks for 64-bit overflows and performs several 32-bit multiples with 64-bit results to check for all possible overflow conditions. IA32 builds using VS20xx with optimizations enabled are producing a reference to the _allmull in