Re: [edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

2019-05-22 Thread Bob Feng
Mike, I missed the second 'SecMain', I'll send another patch to fix it. Bob -Original Message- From: Kinney, Michael D Sent: Thursday, May 23, 2019 6:31 AM To: Gao, Liming ; Feng, Bob C ; devel@edk2.groups.io; Kinney, Michael D Subject: RE: [Patch] BaseTools: Remove './SecMain' from '

Re: [edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

2019-05-22 Thread Michael D Kinney
Hi Bob, I just noticed that there is a 2nd reference to 'SecMain' in build.py that was missed in this patch review. Is there a reason both were not removed? Mike > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, May 21, 2019 8:45 AM > To: Gao, Liming ; Feng, Bob C > ; deve

Re: [edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

2019-05-21 Thread Bob Feng
I entered a new BZ to create the EmulatorPkg postbuild script for "build run" support. https://bugzilla.tianocore.org/show_bug.cgi?id=1828 Thanks, Bob -Original Message- From: Kinney, Michael D Sent: Tuesday, May 21, 2019 11:45 PM To: Gao, Liming ; Feng, Bob C ; devel@edk2.groups.io;

Re: [edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

2019-05-21 Thread Michael D Kinney
Reviewed-by: Michael D Kinney If we want the 'run' target to work for the EmulatorPkg, we can add a python post build script to support that. Please enter a BZ feature request. There is an example in the following edk2-staging branch that runs QEMU for an OvmfPkg build using a 'run' target. ht

Re: [edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

2019-05-21 Thread Liming Gao
Bob: Because NT32 has been removed, this change should be OK. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: Feng, Bob C > Sent: Friday, May 10, 2019 3:34 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Kinney, Michael D > Subject: RE: [Patch] BaseTools: Remove '

Re: [edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

2019-05-10 Thread Bob Feng
I think NT32Pkg need a POSTBUILD scripts to execute its run command. -Original Message- From: Gao, Liming Sent: Friday, May 10, 2019 3:26 PM To: Feng, Bob C ; devel@edk2.groups.io Cc: Kinney, Michael D Subject: RE: [Patch] BaseTools: Remove './SecMain' from 'run' target Bob: Please m

Re: [edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

2019-05-10 Thread Liming Gao
Bob: Please make sure run command still works on NT32 platform. >-Original Message- >From: Feng, Bob C >Sent: Friday, May 10, 2019 2:34 PM >To: devel@edk2.groups.io >Cc: Feng, Bob C ; Gao, Liming >; Kinney, Michael D >Subject: [Patch] BaseTools: Remove './SecMain' from 'run' target > >

[edk2-devel] [Patch] BaseTools: Remove './SecMain' from 'run' target

2019-05-09 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1561 When a target of 'run' is passed into build.py, BaseTools unconditionally attempts to execute the application called './SecMain' in the build output directory. This behavior applies to the Nt32Pkg which is being replaced with features in the