Thank you Mike.
Thanks,
Bob
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, February 10, 2021 9:53 AM
To: Feng, Bob C ; Leif Lindholm ;
Kinney, Michael D
Cc: devel@edk2.groups.io; Liming Gao ; Chen,
Christine ; Matthew Carlson
Subject: RE: [Patch] BaseTools: Fix the end
Pushed
PR: https://github.com/tianocore/edk2/pull/1419
Commit:
https://github.com/tianocore/edk2/pull/1419/commits/c10b513830e63fa4fc28f1edc43352de8d97b61f
Mike
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, February 9, 2021 5:21 PM
> To: Feng, Bob C ; Leif Lindholm
Hi Bob,
Reviewed-by: Michael D Kinney
It is difficult to see the changes. I did verify that the file before the
patch had mixed line
endings and the one after the patch is LF only line endings.
Minor issues with Author name with a ','. I fixed that when I added the rb to
the commit message.
Hi Mike
Could you help review this patch and push it?
Liming may take leave now.
Thanks,
Bob
-Original Message-
From: Leif Lindholm
Sent: Tuesday, February 9, 2021 11:01 PM
To: Feng, Bob C
Cc: devel@edk2.groups.io; Liming Gao ; Chen,
Christine ; Matthew Carlson ;
Kinney, Michael D
On Tue, Feb 09, 2021 at 22:58:08 +0800, Bob Feng wrote:
> Signed-off-by: Bob Feng
> Cc: Liming Gao
> Cc: Yuwei Chen
> Cc: Matthew Carlson
> Cc: Michael D Kinney
> Cc: Leif Lindholm
SMTP strips the intersting aspect, but as long as the end result is a
BuildEnv that has no characters:
Review
Signed-off-by: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Cc: Matthew Carlson
Cc: Michael D Kinney
Cc: Leif Lindholm
---
BaseTools/BuildEnv | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/BaseTools/BuildEnv b/BaseTools/BuildEnv
index 8d283e10c0..27
