V L
> Sent: Wednesday, April 12, 2023 2:16 AM
> To: Warkentin, Andrei
> Cc: devel@edk2.groups.io; Daniel Schaefer ;
> Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang ; Gerd
> Hoffmann
> Subject: Re: [edk2-devel] [PATCH v7 2/3] MdePkg: add SBI-based
> SerialPortLib for RISC-
Thanks, Andrei. Just one nit comment below.
Otherwise, LGTM.
Reviewed-by: Sunil V L
On Fri, Apr 07, 2023 at 04:44:24PM -0500, Andrei Warkentin wrote:
> These are implementations of SerialPortLib using SBI console services.
> - BaseSerialPortLibRiscVSbiLib is appropriate for SEC/PEI (XIP) environ
These are implementations of SerialPortLib using SBI console services.
- BaseSerialPortLibRiscVSbiLib is appropriate for SEC/PEI (XIP) environments
- BaseSerialPortLibRiscVSbiLibRam is appropriate for PrePI/DXE environments
Tested with:
- Qemu RiscVVirt (non-DBCN case, backed by UART)
- TinyEMU +
