Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

2022-10-27 Thread Dionna Glaze via groups.io
> > btw it still fails in CoreTerminateMemoryMap() with the current upstream > kernel which is not aware of the lazy memory acceptance, is this > something known? Thanks, > It wasn't known. I'll take a look. Thanks for the report. -- -Dionna Glaze, PhD (she/her) -=-=-=-=-=-=-=-=-=-=-=- Groups.

Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

2022-10-26 Thread Alexey Kardashevskiy
On 26/10/2022 13:49, Alexey Kardashevskiy wrote: On 26/10/2022 12:35, Alexey Kardashevskiy wrote: On 26/10/2022 12:07, Dionna Amalie Glaze wrote: On Tue, Oct 25, 2022 at 5:23 PM Alexey Kardashevskiy wrote: Hi Dionna, Thanks for updating the tree, builds nicely now! However the VM's

Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

2022-10-25 Thread Alexey Kardashevskiy
On 26/10/2022 12:35, Alexey Kardashevskiy wrote: On 26/10/2022 12:07, Dionna Amalie Glaze wrote: On Tue, Oct 25, 2022 at 5:23 PM Alexey Kardashevskiy wrote: Hi Dionna, Thanks for updating the tree, builds nicely now! However the VM's kernel does not boot - the guest kernel reports EFI

Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

2022-10-25 Thread Alexey Kardashevskiy
On 26/10/2022 12:07, Dionna Amalie Glaze wrote: On Tue, Oct 25, 2022 at 5:23 PM Alexey Kardashevskiy wrote: Hi Dionna, Thanks for updating the tree, builds nicely now! However the VM's kernel does not boot - the guest kernel reports EFI stub: ERROR: exit_boot() failed! and hangs. I am no

Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

2022-10-25 Thread Dionna Glaze via groups.io
On Tue, Oct 25, 2022 at 5:23 PM Alexey Kardashevskiy wrote: > > Hi Dionna, > > Thanks for updating the tree, builds nicely now! However the VM's kernel > does not boot - the guest kernel reports > > EFI stub: ERROR: exit_boot() failed! > > and hangs. I am not quite sure how it is supposed to work

Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

2022-10-25 Thread Alexey Kardashevskiy
Hi Dionna, Thanks for updating the tree, builds nicely now! However the VM's kernel does not boot - the guest kernel reports EFI stub: ERROR: exit_boot() failed! and hangs. I am not quite sure how it is supposed to work (still learning) but "Accepting all memory" happens twice (should it?) a

Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

2022-10-24 Thread aik
Hey! Sorry if this was asked. I was wondering if this patchset is in some git repo which I pull from as I struggle to get a buildable tree by applying this patchset to whatever I can find. I tried https://github.com/deeglaze/edk2.git ( https://github.com/deeglaze/edk2.git ) enable_umv7 but it

Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

2022-10-24 Thread Dionna Glaze via groups.io
> > Hey! > > Sorry if this was asked. I was wondering if this patchset is in some git repo > which I pull from as I struggle to get a buildable tree by applying this > patchset to whatever I can find. > > I tried https://github.com/deeglaze/edk2.git enable_umv7 but it does not > build (missing

Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

2022-10-21 Thread Dionna Glaze via groups.io
> > I suppose that's true. Would you prefer volatile versions of > > OsIndications/OsIndicationsSupported added to the spec, or this > > proposed one-off toggle protocol? No specified global variables seem > > overloadable with this duty. > > > > No it would have to be a completely separate variabl

Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

2022-10-21 Thread Ard Biesheuvel
On Fri, 21 Oct 2022 at 00:37, Dionna Amalie Glaze wrote: > > > That assumes the variable is non-volatile, but I suppose we could use > > a volatile variable [other than OsIndications] as well. > > > > I suppose that's true. Would you prefer volatile versions of > OsIndications/OsIndicationsSupport

Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

2022-10-20 Thread Dionna Glaze via groups.io
> That assumes the variable is non-volatile, but I suppose we could use > a volatile variable [other than OsIndications] as well. > I suppose that's true. Would you prefer volatile versions of OsIndications/OsIndicationsSupported added to the spec, or this proposed one-off toggle protocol? No spec

Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

2022-10-19 Thread Ard Biesheuvel
On Fri, 14 Oct 2022 at 23:30, Dionna Glaze via groups.io wrote: > > > > > Can OsIndicationsSupported UEFI variable provide the similar functionality? > > > > Similar, but not the same. If we use a UEFI variable, its value will > persist across boots. That assumes the variable is non-volatile, but

Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

2022-10-14 Thread Dionna Glaze via groups.io
> > Can OsIndicationsSupported UEFI variable provide the similar functionality? > Similar, but not the same. If we use a UEFI variable, its value will persist across boots. This can be fine if you only boot one OS, but if you have two where one supports unaccepted memory and the other doesn't then

Re: [edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

2022-10-13 Thread Ni, Ray
> > To allow the OS loader to prevent the eager acceptance, we add a new > protocol, up for standardization, AcceptAllUnacceptedMemoryProtocol. > This protocol has one interface, Disable(). The OS loader can inform the > UEFI that it supports the unaccepted memory type and accepts the > responsibi

[edk2-devel] [PATCH v7 0/7] Add safe unaccepted memory behavior

2022-10-05 Thread Dionna Glaze via groups.io
These seven patches build on the lazy-accept patch series "Introduce Lazy-accept for Tdx guest" by adding SEV-SNP support for the MemoryAccept protocol, and importantly making eager memory acceptance the default behavior. We implement a standardized event group from UEFI v2.9, EFI_EVENT_GROUP_BE