Re: [edk2-devel] [PATCH v6 33/52] PurleyOpenBoardPkg: Add SpiFlashCommonLib.h

2021-11-02 Thread Nate DeSimone
Reviewed-by: Nate DeSimone I will correct the commit message during the upstreaming process. Thanks, Nate -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 1:43 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Chiu, Chasel

Re: [edk2-devel] [PATCH v6 33/52] PurleyOpenBoardPkg: Add SpiFlashCommonLib.h

2021-11-01 Thread Michael Kubacki
Thanks for pointing that out. This was a mistake in copying/pasting patch subject lines and your plan to extend WhitleyOpenBoardPkg to use IntelSiliconPkg sounds good. If the package names in the commit message can be corrected before pushing that would be great. Thanks, Michael On 11/1/202

Re: [edk2-devel] [PATCH v6 33/52] PurleyOpenBoardPkg: Add SpiFlashCommonLib.h

2021-11-01 Thread Oram, Isaac W
Reviewed-by: Isaac Oram Please note subject/title and message body indicate PurleyOpenBoardPkg, but actual file is located in WhitleyOpenBoardPkg. I don't see any content difference and think it would be better to modify INF to include IntelSiliconPkg/IntelSiliconPkg.dec. I can do this in the

[edk2-devel] [PATCH v6 33/52] PurleyOpenBoardPkg: Add SpiFlashCommonLib.h

2021-10-28 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307 Adds the header file to PurleyOpenBoardPkg since it was removed from MinPlatformPkg. Cc: Isaac Oram Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Michael Kubacki --- Platform/Intel/WhitleyOpenBoardPkg/Include/