Thanks Sunil, I have in fact missed your email.
Will apply your feedback, retest and resend.
A
> -Original Message-
> From: Sunil V L
> Sent: Thursday, April 6, 2023 12:00 AM
> To: Warkentin, Andrei
> Cc: devel@edk2.groups.io; Daniel Schaefer ;
> Kinney, Michael D ; Gao, Liming
> ; Liu
Hi Andrei,
I had couple of questions on previous version of this patch. Adding them
inline again in case you had missed them. Please check if they are
valid.
Also, I think it would be better to have single directory
BaseSerialPortLibRiscVSbiLib and inside that we can have both INF files.
This way
These are implementations of SerialPortLib using SBI console services.
- BaseSerialPortLibRiscVSbiLib is appropriate for SEC/PEI (XIP) environments
- BaseSerialPortLibRiscVSbiLibRam is appropriate for PrePI/DXE environments
Tested with:
- Qemu RiscVVirt (non-DBCN case, backed by UART)
- TinyEMU +
