Re: [edk2-devel] [PATCH v6 2/2] add ArmCpuInfo EFI application

2023-04-21 Thread Leif Lindholm
On Fri, Apr 21, 2023 at 08:37:42 -0600, Rebecca Cran wrote: > I noticed CI failed for the push PR > (https://github.com/tianocore/edk2/pull/4292). > > > Ecc is complaining about missing Doxygen info for the functions: > > https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=88023&view=

Re: [edk2-devel] [PATCH v6 2/2] add ArmCpuInfo EFI application

2023-04-21 Thread Rebecca Cran
On 4/21/23 08:59, Marcin Juszkiewicz wrote: Thanks for links. Interface for EDK2 CI is not easy for beginners. It really isn't, unfortunately. Doxygen info is something I probably never wrote so would need to look at rest of EDK2 code to find out what it is and how to use it. It's pretty st

Re: [edk2-devel] [PATCH v6 2/2] add ArmCpuInfo EFI application

2023-04-21 Thread Marcin Juszkiewicz
W dniu 21.04.2023 o 16:37, Rebecca Cran pisze: I noticed CI failed for the push PR (https://github.com/tianocore/edk2/pull/4292). Ecc is complaining about missing Doxygen info for the functions: https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=88023&view=logs&j=d36e2059-ab45-57a

Re: [edk2-devel] [PATCH v6 2/2] add ArmCpuInfo EFI application

2023-04-21 Thread Rebecca Cran
I noticed CI failed for the push PR (https://github.com/tianocore/edk2/pull/4292). Ecc is complaining about missing Doxygen info for the functions: https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=88023&view=logs&j=d36e2059-ab45-57a4-e2a1-e73032481054&t=463dc808-035c-5fe4-17fd-50

Re: [edk2-devel] [PATCH v6 2/2] add ArmCpuInfo EFI application

2023-04-20 Thread Leif Lindholm
On Thu, Apr 20, 2023 at 16:44:23 +0200, Marcin Juszkiewicz wrote: > App goes through ID_AA64*_EL1 system registers and decode their values. > > Signed-off-by: Marcin Juszkiewicz For the series: Reviewed-by: Leif Lindholm After discussing with Marcin on side channel, I folded in a statement at

[edk2-devel] [PATCH v6 2/2] add ArmCpuInfo EFI application

2023-04-20 Thread Marcin Juszkiewicz
App goes through ID_AA64*_EL1 system registers and decode their values. Signed-off-by: Marcin Juszkiewicz --- ArmPkg/ArmPkg.dsc|1 + ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.inf | 33 + ArmPkg/Application/ArmCpuInfo/ArmCpuInfo.c | 2346 ++ 3 fi