> This doesn't work currently because the code
> considers a pcie host bridge without I/O window a hard failure even in
> case there are no I/O allocation requests. For fixing that the five
> lines above should be enough I think.
That's a real bug we should fix. I agree!!
-=-=-=-=-=-=-=-=-=-=
Hi,
> To make things worse I see that if we return success there EDK2 will
> actually go ahead and start assigning trash addresses to the device
> and enable IO space decoding in case of the PCI root port which means
> that device will try to decode invalid IO ranges.
> Logs:
> PciBus: Resourc
On Mon, May 23, 2022 at 11:24 PM, Gerd Hoffmann wrote:
>
> On Mon, May 23, 2022 at 04:48:05AM -0700, Albecki, Mateusz wrote:
>
>> @Ni, Ray
>>
>> I think EDK2 needs to provide a way for root port to operate without IO
>> space assigned in a platform-independent way. I can think of the following
On Mon, May 23, 2022 at 04:48:05AM -0700, Albecki, Mateusz wrote:
> @Ni, Ray
>
> I think EDK2 needs to provide a way for root port to operate without IO space
> assigned in a platform-independent way. I can think of the following cases
> when root port didn't get IO space:
>
> 1. We have run ou
@Ni, Ray
I think EDK2 needs to provide a way for root port to operate without IO space
assigned in a platform-independent way. I can think of the following cases when
root port didn't get IO space:
1. We have run out of IO space but it's fine since the device under the root
port doesn't use IO
Hi,
> If IO requirement of certain PCI(E) devices can be ignored, can you change
> the IncompatiblePciDevice protocol implementation to override the IO request
> from the devices?
Hmm, how can the IncompatiblePciDevice protocol specify that IO bars
should be ignored?
Seems I can override the
Hi,
> > > Can Linux allocate resource for PCI(E) devices? How does it deal with the
> > > IO type?
> >
> > Yes. Details depend a bit on the specific configuration, but in general
> > linux will try assign io address space to pcie root ports and devices
> > plugged into those ports. A failure
>
> Hi,
>
> > > I'd say the risk for regressions is rather low, though, given that it
> > > only affects configurations that would fail PCI resource allocation
> > > today. Or am I missing something?
> > >
> > > In any case, the PCIe spec is clear about this: I/O space is optional,
> > > and we
Hi,
> > I'd say the risk for regressions is rather low, though, given that it
> > only affects configurations that would fail PCI resource allocation
> > today. Or am I missing something?
> >
> > In any case, the PCIe spec is clear about this: I/O space is optional,
> > and we need to incorpora
t; ; Leif Lindholm ; Justen,
> Jordan L ; Yao,
> Jiewen ; Chang, Abner ; Wang, Jian
> J
> Subject: Re: [edk2-devel] [PATCH v5 1/6] MdeModulePkg/PciHostBridge: io range
> is not mandatory
>
> On Fri, 29 Apr 2022 at 08:50, Gerd Hoffmann wrote:
> >
> > On Wed
On Fri, 29 Apr 2022 at 08:50, Gerd Hoffmann wrote:
>
> On Wed, Apr 27, 2022 at 03:08:50AM +, Ni, Ray wrote:
> > Ard,
> > can you explain more?
> >
> > Your code changes the PciHostBridge driver to ignore the failure of IO
> > allocation.
> > If IO requirement of certain PCI(E) devices can be
On Wed, Apr 27, 2022 at 03:08:50AM +, Ni, Ray wrote:
> Ard,
> can you explain more?
>
> Your code changes the PciHostBridge driver to ignore the failure of IO
> allocation.
> If IO requirement of certain PCI(E) devices can be ignored, can you change
> the IncompatiblePciDevice protocol imple
, Jiewen ; Chang,
> Abner ; Wang, Jian J
> Subject: Re: [edk2-devel] [PATCH v5 1/6] MdeModulePkg/PciHostBridge: io range
> is not mandatory
>
> Ard,
> can you explain more?
>
> Your code changes the PciHostBridge driver to ignore the failure of IO
> allocation.
> If I
> ; Leif Lindholm ; Justen,
> Jordan L ; Yao,
> Jiewen ; Chang, Abner ; Wang, Jian
> J
> Subject: Re: [edk2-devel] [PATCH v5 1/6] MdeModulePkg/PciHostBridge: io range
> is not mandatory
>
> On Fri, 22 Apr 2022 at 09:37, Gerd Hoffmann wrote:
> >
> > io ran
wen Yao ;
> Abner Chang ; Jian J Wang
> 主题: Re: [edk2-devel] [PATCH v5 1/6] MdeModulePkg/PciHostBridge: io
> range is not mandatory
>
> On Fri, 22 Apr 2022 at 09:37, Gerd Hoffmann wrote:
> >
> > io range is not mandatory according to pcie spec,
> > so al
On Fri, 22 Apr 2022 at 09:37, Gerd Hoffmann wrote:
>
> io range is not mandatory according to pcie spec,
> so allow bridge configurations without io address
> space assigned.
>
> Signed-off-by: Gerd Hoffmann
> Reviewed-by: Ard Biesheuvel
Could one of the MdeModulePkg maintainers please get this
io range is not mandatory according to pcie spec,
so allow bridge configurations without io address
space assigned.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Ard Biesheuvel
---
MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MdeModule
17 matches
Mail list logo
