Re: [edk2-devel] [PATCH v5 1/4] Silicon/ARM/NeoverseN1Soc: Port PCI Segment Library

2022-01-19 Thread Sami Mujawar
Hi Khasim, Thank you for this patch. Please find my feedback marked inline as [SAMI]. Regards, Sami Mujawar On 22/12/2021 01:14 AM, Khasim Mohammed via groups.io wrote: The BasePCISegment Library in MdePkg doesn't allow configuring multiple segments required for PCIe and CCIX root port enum

Re: [edk2-devel] [PATCH v5 1/4] Silicon/ARM/NeoverseN1Soc: Port PCI Segment Library

2021-12-22 Thread PierreGondois
Hi Khasim, Everything looks good to me: Reviewed-by: Pierre Gondois Regards, Pierre On 12/22/21 2:14 AM, Khasim Mohammed via groups.io wrote: > The BasePCISegment Library in MdePkg doesn't allow configuring > multiple segments required for PCIe and CCIX root port > enumeration. Therefore, a cu

[edk2-devel] [PATCH v5 1/4] Silicon/ARM/NeoverseN1Soc: Port PCI Segment Library

2021-12-21 Thread Khasim Mohammed
The BasePCISegment Library in MdePkg doesn't allow configuring multiple segments required for PCIe and CCIX root port enumeration. Therefore, a custom PCI Segment library is adapted from SynQuacerPciSegmentLib and ported for N1Sdp. In addition to this, the hardware has few other limitations which