Re: [edk2-devel] [PATCH v4 2/6] OvmfPkg: Add QemuFwCfgLibNull

2020-04-28 Thread Rebecca Cran
On 4/28/20 5:27 AM, Philippe Mathieu-Daudé wrote: I'll fix this if/when I need to send a v5 series out, or since it doesn't seem to do any harm in a later patch. OK. Changing by : Reviewed-by: Philippe Mathieu-Daude Oh, I see my mistake. There's QemuFwCfg.h and QemuFwCfgLib.h and I

Re: [edk2-devel] [PATCH v4 2/6] OvmfPkg: Add QemuFwCfgLibNull

2020-04-28 Thread Philippe Mathieu-Daudé
On 4/27/20 7:33 PM, Rebecca Cran wrote: On 4/27/20 3:03 AM, Philippe Mathieu-Daudé wrote: +#include +#include +#include Don't you need ? Hmm, you're right. I'm not sure where I got "IndustryStandard/QemuFwCfg.h" from, though I noticed QemuFwCfg.h itself includes a nonexistent version

Re: [edk2-devel] [PATCH v4 2/6] OvmfPkg: Add QemuFwCfgLibNull

2020-04-27 Thread Rebecca Cran
On 4/27/20 3:03 AM, Philippe Mathieu-Daudé wrote: +#include +#include +#include Don't you need ? Hmm, you're right. I'm not sure where I got "IndustryStandard/QemuFwCfg.h" from, though I noticed QemuFwCfg.h itself includes a nonexistent version in IndustryStandard! #ifndef __FW_CFG

Re: [edk2-devel] [PATCH v4 2/6] OvmfPkg: Add QemuFwCfgLibNull

2020-04-27 Thread Philippe Mathieu-Daudé
Hi Rebecca, On 4/24/20 8:29 PM, Rebecca Cran wrote: Add a null implementation library for QemuFwCfgLib, in order to support building PciHostBridgeLib for bhyve. Signed-off-by: Rebecca Cran --- .../Library/QemuFwCfgLib/QemuFwCfgLibNull.inf | 37 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNu

[edk2-devel] [PATCH v4 2/6] OvmfPkg: Add QemuFwCfgLibNull

2020-04-24 Thread Rebecca Cran
Add a null implementation library for QemuFwCfgLib, in order to support building PciHostBridgeLib for bhyve. Signed-off-by: Rebecca Cran --- .../Library/QemuFwCfgLib/QemuFwCfgLibNull.inf | 37 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c | 209 ++ 2 files changed, 246 inse