Re: [edk2-devel] [PATCH v4 10/13] OvmfPkg/MptScsiDxe: Initialize hardware

2020-04-20 Thread Laszlo Ersek
On 04/14/20 19:38, Nikita Leshenko wrote: > diff --git a/OvmfPkg/Include/IndustryStandard/FusionMptScsi.h > b/OvmfPkg/Include/IndustryStandard/FusionMptScsi.h Some notes related to edk2's CamelCase style: > +#pragma pack (1) > +typedef struct { > + UINT8 WhoInit; > + UINT8 Reserved1;

Re: [edk2-devel] [PATCH v4 10/13] OvmfPkg/MptScsiDxe: Initialize hardware

2020-04-20 Thread Laszlo Ersek
On 04/16/20 18:00, Nikita Leshenko wrote: > > >> On 16 Apr 2020, at 12:53, Laszlo Ersek wrote: >> >> On 04/14/20 19:38, Nikita Leshenko wrote: [...] > I break out the inner structs into separate typedefs, wrap all of them in > #pragma pack (1) / pack () and then create the wrapping aligning un

Re: [edk2-devel] [PATCH v4 10/13] OvmfPkg/MptScsiDxe: Initialize hardware

2020-04-16 Thread Nikita Leshenko
> On 16 Apr 2020, at 12:53, Laszlo Ersek wrote: > > On 04/14/20 19:38, Nikita Leshenko wrote: >> Reset and send the IO controller initialization request. The reply is >> read back to complete the doorbell function but it isn't useful to us >> because it doesn't contain relevant data or status

Re: [edk2-devel] [PATCH v4 10/13] OvmfPkg/MptScsiDxe: Initialize hardware

2020-04-16 Thread Laszlo Ersek
On 04/14/20 19:38, Nikita Leshenko wrote: > Reset and send the IO controller initialization request. The reply is > read back to complete the doorbell function but it isn't useful to us > because it doesn't contain relevant data or status codes. > > See "LSI53C1030 PCI-X to Dual Channel Ultra320 S

[edk2-devel] [PATCH v4 10/13] OvmfPkg/MptScsiDxe: Initialize hardware

2020-04-14 Thread Nikita Leshenko
Reset and send the IO controller initialization request. The reply is read back to complete the doorbell function but it isn't useful to us because it doesn't contain relevant data or status codes. See "LSI53C1030 PCI-X to Dual Channel Ultra320 SCSI Multifunction Controller" technical manual for m