Re: [edk2-devel] [PATCH v4 1/1] ProcessorPkg/Library: Add RiscVEdk2SbiLib

2020-06-22 Thread Abner Chang
-Original Message- > From: Leif Lindholm [mailto:l...@nuviainc.com] > Sent: Friday, June 19, 2020 12:50 AM > To: devel@edk2.groups.io; Schaefer, Daniel (DualStudy) > > Cc: Chen, Gilbert ; Chang, Abner (HPS SW/FW > Technologist) ; Michael D . Kinney > > Subject: Re:

Re: [edk2-devel] [PATCH v4 1/1] ProcessorPkg/Library: Add RiscVEdk2SbiLib

2020-06-18 Thread Leif Lindholm
On Tue, Jun 02, 2020 at 18:51:52 +0200, Daniel Schaefer wrote: > Library provides interfaces to invoke SBI ecalls. > > Signed-off-by: Daniel Schaefer All of my feedback on previous revision addressed - where to actually *merge* it remains undecided, but for the contents: Reviewed-by: Leif Lindho

Re: [edk2-devel] [PATCH v4 1/1] ProcessorPkg/Library: Add RiscVEdk2SbiLib

2020-06-02 Thread Abner Chang
groups.io; Schaefer, Daniel (DualStudy) > > ; Kinney, Michael D > > > > Cc: Leif Lindholm ; Chen, Gilbert > > ; Chang, Abner (HPS SW/FW Technologist) > > > > Subject: RE: [edk2-devel] [PATCH v4 1/1] ProcessorPkg/Library: Add > > RiscVEdk2SbiLib > > > &

Re: [edk2-devel] [PATCH v4 1/1] ProcessorPkg/Library: Add RiscVEdk2SbiLib

2020-06-02 Thread Abner Chang
(HPS SW/FW Technologist) > > Subject: RE: [edk2-devel] [PATCH v4 1/1] ProcessorPkg/Library: Add > RiscVEdk2SbiLib > > Hi Daniel, > > I see some inconsistence in the names used in these patches. > > For example, there should not be a need to use "Edk2" in the > n

Re: [edk2-devel] [PATCH v4 1/1] ProcessorPkg/Library: Add RiscVEdk2SbiLib

2020-06-02 Thread Michael D Kinney
to the bit width? Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Daniel Schaefer > Sent: Tuesday, June 2, 2020 9:52 AM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Gilbert Chen > ; Abner Chang > ; Kinney, Michael D > >

[edk2-devel] [PATCH v4 1/1] ProcessorPkg/Library: Add RiscVEdk2SbiLib

2020-06-02 Thread Daniel Schaefer
Library provides interfaces to invoke SBI ecalls. Signed-off-by: Daniel Schaefer Cc: Leif Lindholm Cc: Gilbert Chen Cc: Abner Chang Cc: Michael D. Kinney --- Silicon/RISC-V/ProcessorPkg/Library/RiscVEdk2SbiLib/RiscVEdk2SbiLib.inf | 28 + Silicon/RISC-V/ProcessorPkg/Include/Library/RiscVEdk