Re: [edk2-devel] [PATCH v4 0/8] Adjust the QemuFwCfgLibMmio and add PEI stage

2024-04-29 Thread Chao Li
Thanks, Chao On 2024/4/29 15:14, Ard Biesheuvel wrote: On Mon, 29 Apr 2024 at 09:09, Chao Li wrote: Hi Ard, OK, I will make adjustments according to your suggestions and submit the V5 today. No, please do not make any adjustments. I will take the v4 and apply these changes directly. Plea

Re: [edk2-devel] [PATCH v4 0/8] Adjust the QemuFwCfgLibMmio and add PEI stage

2024-04-29 Thread Ard Biesheuvel
On Mon, 29 Apr 2024 at 09:09, Chao Li wrote: > > Hi Ard, > > OK, I will make adjustments according to your suggestions and submit the V5 > today. > No, please do not make any adjustments. I will take the v4 and apply these changes directly. Please do not send another revision unless there are o

Re: [edk2-devel] [PATCH v4 0/8] Adjust the QemuFwCfgLibMmio and add PEI stage

2024-04-29 Thread Chao Li
Hi Ard, OK, I will make adjustments according to your suggestions and submit the V5 today. Thanks, Chao On 2024/4/29 14:56, Ard Biesheuvel wrote: On Mon, 29 Apr 2024 at 03:17, Chao Li wrote: Hi Ard and Gerd and other maintainers, Could you review this version and give your suggestions?

Re: [edk2-devel] [PATCH v4 0/8] Adjust the QemuFwCfgLibMmio and add PEI stage

2024-04-28 Thread Ard Biesheuvel
On Mon, 29 Apr 2024 at 03:17, Chao Li wrote: > > Hi Ard and Gerd and other maintainers, > > Could you review this version and give your suggestions? > This looks ok to me now, modulo a few minor tweaks (see below) that I will apply when merging. I also changed the type signatures to extern VOID

Re: [edk2-devel] [PATCH v4 0/8] Adjust the QemuFwCfgLibMmio and add PEI stage

2024-04-28 Thread Chao Li
Hi Ard and Gerd and other maintainers, Could you review this version and give your suggestions? Thanks, Chao On 2024/4/26 16:28, Chao Li wrote: Patch1: Added three PCDs for QemuFwCfgLibMmio Patch2: Sparate QemuFwCfgLibMmio.c into two files and default as DXE stage library. Patch3: Added QemuFw

[edk2-devel] [PATCH v4 0/8] Adjust the QemuFwCfgLibMmio and add PEI stage

2024-04-26 Thread Chao Li
Patch1: Added three PCDs for QemuFwCfgLibMmio Patch2: Sparate QemuFwCfgLibMmio.c into two files and default as DXE stage library. Patch3: Added QemuFwCfgMmiLib PEI version Patch4: Rename QemuFwCfgLibMmio.inf to QemuFwCfgMmioDxeLib.inf and enable it in AARCH64 and RISCV64. V1 -> V2: 1. Use HOBs i