Thanks for the explanation, Mike! Also, I noticed during rebasing my original
commit (BZ: 2151) that PcdSetxx does not work with PcdsFixedAtBuild anymore,
which, should be by design.
Please ignore patch v5 as patch v6 contains all the fixes.
~ Amol
-Original Message-
From: Kinney, Mich
Amol,
FixedPcdGet32() does not apply to this use case.
FixedPcdGet32() is usually only used when a PCD value
is used to fill in a field of a structure in a global
variable where the compiler requires a value instead
of a variable or a function call.
The general rule is to use PcdGet/Setxx() eve
Hi Mike,
Yes, I just noticed and sent the patch with update 1 (build passed and worked
with PcdGet16). I didn't notice the second change so I will make it as well in
version 6.
Question: There is a call FixedPcdGet32 as well. Would it be applicable in
BaseHashApiLib?
Thanks,
Amol
-Origin
Hi Amol,
Thanks for the updates:
There are a couple items remaining:
1) BaseHashApiLib needs to use PcdGet32() instead of PcdGet16()
2) The extra [PcdsFixedAtBuild] line needs to be removed from CryptoPkg.dec
Thanks,
Mike
> -Original Message-
> From: Sukerkar, Amol N
> Sent: Friday,
This patch implements the fixes and enhancement to BaseHashApiLib in
the following manner:
- Remove reference to MD4 and MD5 hashing algorithms as they are
deprecated;
- Align the enumeration for hashing algorithmswith the one used in
TPM 2.0 implementation defined in IndustryStandard/Tpm20.h;
