Re: [edk2-devel] [PATCH v3 7/7] DynamicTablesPkg: Add CacheId to PPTT generator

2021-12-09 Thread Chris Jones
Hi Sami, The optimisation looks good to me and I would be glad if you added it to the patch. Thanks, Chris From: Sami Mujawar Sent: Thursday, December 9, 2021 1:19 PM To: Christopher Jones ; devel@edk2.groups.io Cc: michael.d.kin...@intel.com ; gaolim...@byos

Re: [edk2-devel] [PATCH v3 7/7] DynamicTablesPkg: Add CacheId to PPTT generator

2021-12-09 Thread Sami Mujawar
Hi Chris, Thank you for this patch. Please see my feedback below inline marked [SAMI]. Regards, Sami Mujawar On 08/12/2021 04:06 PM, Chris Jones wrote: Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the PPTT generator with the CacheId field as defined in table

[edk2-devel] [PATCH v3 7/7] DynamicTablesPkg: Add CacheId to PPTT generator

2021-12-08 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the PPTT generator with the CacheId field as defined in table 5.140 of the ACPI 6.4 specification. Also add validations to ensure that the cache id generated is unique. Signed-off-by: Chris Jones --- DynamicTablesPkg/I